fix: improve performance of snapshot sorting #681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnu
commented
Jan 26, 2023
| return [cls.__maybe_int(part) for part in snapshot.name.split(".")] | ||
| if "." in snapshot.name: | ||
| index = snapshot.name.rfind(".") + 1 | ||
| return f"{snapshot.name[:index-1]}.{snapshot.name[index:].zfill(4)}" |
There was a problem hiding this comment.
The zfill is arbitrary but should ensure sorting of at least 1000 assertions within a single test case.
Codecov Report
@@ Coverage Diff @@
## next #681 +/- ##
==========================================
+ Coverage 98.57% 98.63% +0.06%
==========================================
Files 20 20
Lines 1402 1396 -6
==========================================
- Hits 1382 1377 -5
+ Misses 20 19 -1 |
|
This PR doesn't solve the perf issues. Will have to do some actual profiling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior art: #680
Addresses: #657