test: handle case where both pyargs and test file given #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamogbz
commented
Jun 3, 2021
| result = run_testcases.runpytest( | ||
| "-v", "test_file.py", "--pyargs", "test_file", "--snapshot-update" | ||
| ) | ||
| assert result.ret == 0 |
There was a problem hiding this comment.
Would fail with ModuleNotFoundError: No module named 'test_file.py'; 'test_file' is not a package if the Exception was not handled.
pull request head sha does not match latest commit
iamogbz
commented
Jun 3, 2021
.github/workflows/cicd.yml
Outdated
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| # Github pull request event has the merge commit as the HEAD on checkout | ||
| # https://github.com/actions/checkout/issues/261 | ||
| COMMIT_SHA: ${{ github.event.after }} |
There was a problem hiding this comment.
Using COMMIT_SHA as GITHUB_SHA does not seem to be overridable
noahnu
approved these changes
Jun 3, 2021
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing test coverage for #507
Checklist
Additional Comments
No additional comments.