Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin pytest version to range #111

Merged
merged 3 commits into from
Jan 14, 2020
Merged

chore: pin pytest version to range #111

merged 3 commits into from
Jan 14, 2020

Conversation

noahnu
Copy link
Collaborator

@noahnu noahnu commented Jan 14, 2020

Description

This PR specifies a version range for pytest.

Also went ahead and updated dev & test dependencies.

Related Issues

Checklist

  • This PR has sufficient test coverage.
  • I have updated the CHANGELOG.md.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #111   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         704    704           
=====================================
  Hits          704    704

@noahnu noahnu requested a review from iamogbz January 14, 2020 03:42
]
test_requires = [
"codecov",
"coverage[toml]",
"invoke",
"pytest",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nb. should it be in both? As in both install_requires and test_requires

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always install "install requires", so I don't think it's necessary

@noahnu noahnu merged commit 82c8ebe into master Jan 14, 2020
@noahnu noahnu deleted the pytest_dependency branch January 14, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pytest as a dependency
2 participants