Allow WriteImageDataFunction() callback to be called with empty images #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptc-tgamper
commented
Jul 9, 2024
|
Please create PR for each issues(if issues are orthogonal) |
ptc-tgamper
force-pushed
the
bug/issue-495
branch
from
66e9fae
to
a83a16f
Compare
ptc-tgamper
force-pushed
the
bug/issue-495
branch
from
a83a16f
to
fe3cfbe
Compare
ptc-tgamper
commented
Jul 23, 2024
| @@ -2767,6 +2767,12 @@ bool WriteImageData(const std::string *basepath, const std::string *filename, | |||
| const Image *image, bool embedImages, | |||
| const FsCallbacks* fs_cb, const URICallbacks *uri_cb, | |||
| std::string *out_uri, void *) { | |||
| // Early out on empty images, report the original uri if the image was not written. | |||
| if (image->image.empty()) { | |||
There was a problem hiding this comment.
With this we keep the previous behaviour, although the callback is now invoked for empty images.
ptc-tgamper
commented
Jul 23, 2024
| bool imageWritten = false; | ||
| if (WriteImageData != nullptr && !filename.empty() && !image.image.empty()) { | ||
| if (WriteImageData != nullptr && !filename.empty()) { |
There was a problem hiding this comment.
Invoke the callback for empty images
|
I tailored this branch now to the specific issue, nothing more. Please review. |
|
You should describe the summary of what this PR is. |
ptc-tgamper
changed the title
|
Is it ok to merge now, or am I still missing something? @syoyo ? |
|
Good! Merged! The description become clear. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow WriteImageDataFunction() callback to be called with empty images.
The motivation on our side is that we want to avoid to load any image data into memory at all, as we have to deal with models that use multiple Gigabytes (compressed size) of textures. Thus we are looking to employ a custom image loader and writer, where the first does not load/decode any image data, and the second is still called for those empty images.