Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for email domains with no letters #5

Closed
wants to merge 1 commit into from
Closed

Fix for email domains with no letters #5

wants to merge 1 commit into from

Conversation

Trott
Copy link
Contributor

@Trott Trott commented Sep 24, 2021 •
edited
Loading

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

GitHub does not link strings of the format
mdast-util-gfm-autolink-literal@1.0.1 but will link if you add a letter
to the label/domain. Emulate that behavior.

Ref: remarkjs/remark#862

@Trott
Fix for email domains with no letters
eb64073 
GitHub does not link strings of the format
mdast-util-gfm-autolink-literal@1.0.1 but will link if you add a letter
to the label/domain. Emulate that behavior.

Ref: remarkjs/remark#862
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Sep 24, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 24, 2021
@wooorm
Copy link
Member

wooorm commented Sep 24, 2021

I can confirm that both algorithms employed by GH do not link them. I also tested some other semver versions:

react@0.11.1
react@0.12.0-rc1
react@0.14.0-alpha1
react@16.7.0-alpha.2
react@0.0.0-experimental-aae83a4b9

[ react@0.11.1
[ react@0.12.0-rc1
[ react@0.14.0-alpha1
[ react@16.7.0-alpha.2
[ react@0.0.0-experimental-aae83a4b9

react@0.11.1
react@0.12.0-rc1
react@0.14.0-alpha1
react@16.7.0-alpha.2
react@0.0.0-experimental-aae83a4b9

[ react@0.11.1
[ react@0.12.0-rc1
[ react@0.14.0-alpha1
[ react@16.7.0-alpha.2
[ react@0.0.0-experimental-aae83a4b9

wooorm added a commit to micromark/micromark-extension-gfm-autolink-literal that referenced this pull request Sep 24, 2021
@wooorm
Add tests for semver-like ranges
6a143b0 
Related to d9eacf4.
Related to remarkjs/remark#862.
Related to syntax-tree/mdast-util-gfm-autolink-literal#5.
@wooorm
Copy link
Member

wooorm commented Sep 24, 2021 •
edited
Loading

Investigating some more. I think the only rule between whether something links is whether the last character is a digit?

react@a
react@1
react@1.a
react@1.1
react@1.a-b
react@1.a1b
react@1.1-b
react@1.1-alpha
react@1.1-alpha1
react@1.1-a
react@1.a-1

@wooorm wooorm closed this in 7555d45 Sep 24, 2021
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix 💪 phase/solved Post is done 🗄 area/interface This affects the public interface labels Sep 24, 2021
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trott @wooorm