Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLT-234] feat(rfq): dynamic block conf wait + receipt x event quote check w/ RPC consensus #3190

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+398 −85

[goreleaser]

5bc3004
Select commit
Loading
Failed to load commit list.
Open

[SLT-234] feat(rfq): dynamic block conf wait + receipt x event quote check w/ RPC consensus #3190

[goreleaser]
5bc3004
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 16, 2024 in 0s

33.07430% (-7.90374%) compared to f0b13bc

View this Pull Request on Codecov

33.07430% (-7.90374%) compared to f0b13bc

Details

Codecov Report

Attention: Patch coverage is 55.66038% with 47 lines in your changes missing coverage. Please review.

Project coverage is 33.07430%. Comparing base (f0b13bc) to head (5bc3004).
Report is 135 commits behind head on master.

Files with missing lines Patch % Lines
services/rfq/relayer/limiter/limiter.go 66.29213% 24 Missing and 6 partials ⚠️
services/rfq/relayer/service/statushandler.go 0.00000% 9 Missing ⚠️
services/rfq/relayer/relconfig/getters.go 0.00000% 7 Missing ⚠️
services/rfq/util/util.go 0.00000% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f0b13bc) and HEAD (5bc3004). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f0b13bc) HEAD (5bc3004)
solidity 2 0
Additional details and impacted files 
@@                 Coverage Diff                 @@
##              master       #3190         +/-   ##
===================================================
- Coverage   40.97804%   33.07430%   -7.90374%     
===================================================
  Files            459         535         +76     
  Lines          25643       33715       +8072     
  Branches         343          82        -261     
===================================================
+ Hits           10508       11151        +643     
- Misses         14383       21575       +7192     
- Partials         752         989        +237

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov