Feat/rest api upgrade #1193
Closed
Feat/rest api upgrade #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o not visually move when updating
…/sanguine into feat/rest-api-upgrade
bigboydiamonds
requested review from
abtestingalpha,
nautsimon,
aureliusbtc,
trajan0x and
Defi-Moses
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1193 +/- ##
===================================================
- Coverage 59.55215% 59.28892% -0.26324%
===================================================
Files 563 533 -30
Lines 33270 32092 -1178
Branches 275 275
===================================================
- Hits 19813 19027 -786
+ Misses 11670 11357 -313
+ Partials 1787 1708 -79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…napsecns/sanguine into feat/rest-api-upgrade" This reverts commit 2ef7be1, reversing changes made to d9c4f4c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creation of #1167
Description
This upgrade reconfigures dependencies so that it is compatible with heroku deployment, adds two new functions that allow users to generate the raw transaction data in python (so they can acutually bridge once connected to Web3), and updates the ReadMe.
Additional context
Ideally @nautsimon @dwasse can review the two new functions (very slight changes) to confirm that the output transaction data is correct. This also probably needs more robust testing
Metadata
Fixes #[Link to Issue]