Feat/rest api upgrade #1167
Merged
Feat/rest api upgrade #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1167 +/- ##
===================================================
+ Coverage 59.08061% 59.17362% +0.09300%
===================================================
Files 538 565 +27
Lines 32217 33302 +1085
Branches 275 275
===================================================
+ Hits 19034 19706 +672
- Misses 11479 11797 +318
- Partials 1704 1799 +95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dwasse
reviewed
Jul 26, 2023
| ` | ||
| <h1>Invalid Params</h1> | ||
| <hr/> | ||
| <b>Ensure that your request matches the following format: /swap?chain=1&fromToken=USDC&toToken=DAI&amount=100</b> |
There was a problem hiding this comment.
Probably want /swapTxInfo instead of /swap here right?
|
LGTM |
abtestingalpha
added a commit
that referenced
this pull request
Jul 31, 2023
This reverts commit f8efa3d.
Closed
trajan0x
added a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrade reconfigures dependencies so that it is compatible with heroku deployment, adds two new functions that allow users to generate the raw transaction data in python (so they can acutually bridge once connected to Web3), and updates the ReadMe.
Additional context
Ideally @nautsimon @dwasse can review the two new functions (very slight changes) to confirm that the output transaction data is correct. This also probably needs more robust testing
Metadata