This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
[SYM-5071] Ensure on_change implementations are base64 encoded #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating with the API
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
llam15
approved these changes
Aug 18, 2023
Co-authored-by: Leslie Lam <leslie@symops.io>
Arianna2028
deleted the
ari/sym-5071-ensure-on_change-impls-are-base64-encoded
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently on main (but not released to the public, so this is a safe change), on_change implementations are sent as-is to the API and read as such. However, to match all other implementations, we want to communicate them as base64 encoded strings.
Screenshots
The API data is base64 encoded
The Terraform state data is NOT base64 encoded
Create
No changes detected
Update
Destroy
