Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Improve accessibility of tabs and some links #48762

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This improves Profiler accessibility a bit by:

  • Showing an outline in "link buttons" when navigating with the keyboard
  • Adding full ARIA attributes to our tabs, which are common in many panels

@javiereguiluz
Copy link
Member Author

Thanks for the review @stof. I did all the changes that your requested, including certain HTML structure changes to make it fully accessible.

@fabpot
Copy link
Member

fabpot commented Jan 11, 2023

Thank you @javiereguiluz.

@fabpot fabpot merged commit a8ad6bb into symfony:6.3 Jan 11, 2023

<li class="{{ has_error_logs ? 'active' }}">
<button role="tab" class="tab-control {{ has_error_logs ? 'active' }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This template puts an input inside a button, which is invalid HTML markup (and inaccessible one). You cannot have it being both a radio group and an ARIA tablist AFAICT.

Copy link
Member Author

@javiereguiluz javiereguiluz Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to fix it in a separate PR. Thanks.

Update: here's the PR: #48963

@javiereguiluz javiereguiluz deleted the accessibility branch January 12, 2023 10:10
fabpot added a commit that referenced this pull request Jan 14, 2023
…anel filters (javiereguiluz)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #48762 (comment)
| License       | MIT
| Doc PR        | -

This only changes the HTML contents of the logger profiler panel to make them valid (and keeps them accessible). No feature or behavior was changed.

Commits
-------

a8523cb [WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters
symfony-splitter pushed a commit to symfony/web-profiler-bundle that referenced this pull request Jan 14, 2023
…anel filters (javiereguiluz)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | symfony/symfony#48762 (comment)
| License       | MIT
| Doc PR        | -

This only changes the HTML contents of the logger profiler panel to make them valid (and keeps them accessible). No feature or behavior was changed.

Commits
-------

a8523cb091 [WebProfilerBundle] [WebProfilerPanel] Update the logger panel filters
@fabpot fabpot mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants