Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] use a custom batch size #20054

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 19, 2024

reverts #19953 so that the code matches the comment above the method

@carsonbot carsonbot added this to the 6.4 milestone Jul 19, 2024
@xabbuh
Copy link
Member Author

xabbuh commented Jul 19, 2024

But I wonder if we shouldn't simply not show this way to change the batch size but simply keep the overridden getBatchSize() method to showcase this use case?

@carsonbot carsonbot changed the title use a custom batch size [Messenger] use a custom batch size Jul 19, 2024
@javiereguiluz javiereguiluz merged commit ffc2200 into symfony:6.4 Jul 19, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Thanks Christian. I agree with you: this example looks bad because we're overriding the shouldFlush() method to do something that it's easier and makes more sense when overriding the getBatchSize() method.

So, I removed this while merging: a51bc50

@xabbuh xabbuh deleted the pr-19953 branch July 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants