[Form] Remove paragraph on legacy_error_messages config
#17478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `legacy_error_messages` config node is deprecated since 6.2 (see symfony/symfony#47598), it should probably not be mentioned in the docs any longer.
manuelkiessling
changed the title
OskarStark
changed the title
legacy_error_messages config
|
Not sure about removing it in .. deprecated::
Using ``legacy_error_messages`` is deprecated since Symfony 6.2.WDYT @symfony/team-symfony-docs ? |
|
I'm ok with fully removing it. If you search for this specific option (because you see it in your code or some blog post), you should still, in theory, find the result in an older version of the docs. |
|
I was divided, but at the end I opted for doing what Ryan said. This is a very uncommon config option anyways. Thanks. |
|
I was going to merge this ... but I can't because of this error: @OskarStark can you try to merge this? Thanks |
|
Thank you Manuel. |
|
It worked @javiereguiluz ✅ |
javiereguiluz
added a commit
that referenced
this pull request
Sep 25, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [Form] Remove legacy message IIUC what happened with #17478 and [related code PR](symfony/symfony#47598), legacy invalid message refer to something which no longer exists Commits ------- 6516a9b form/remove-legacy-message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
legacy_error_messagesconfig node is deprecated since 6.2 (see symfony/symfony#47598), it should probably not be mentioned in the docs any longer.