feat: support image preview in Windows Terminal

[e82eric]

⚠️ Note: The DA1 response in Windows Terminal Preview 1.22.2362.0 is currently broken, which can cause Yazi to timeout on startup. It's recommended to use this patch from microsoft/terminal#17833 to experience the image preview feature.

---

Hi! The latest version of windows terminal supports Sixel (https://github.com/microsoft/terminal/releases/tag/v1.22.2362.0) microsoft/terminal#17421.

I wanted to make an attempt at updating Yazi to add support. This looked like it would work for both images and video. This may cause a regression for older versions of windows terminal since it won't fallback to chafa.

[sxyazi]

Yazi already supports Sixel through the standard DA1 request. This means that as long as MS Terminal correctly sends the response indicating Sixel support, Yazi can recognize it without needing any additional detection.

But the DA1 response in Windows Terminal Preview 1.22.2362.0 is currently broken, so I can accept this PR as a temporary workaround until they fix it.

[e82eric]

Ahh, I was wondering about that exact part of the code, it was taking 10s to load and I saw that it was waiting for that da1 and timing out. I will try and pull down that windows terminal branch and give it a try.

[sxyazi]

Thanks!

[sxyazi]

Hi @e82eric, could you send me an mp4 version of the PR gif demo? If possible, it would be great if you could make the window a bit smaller.

I want to use it as the demo video for the upcoming version 0.3.3 release - Yazi is probably the first terminal file manager to support image preview in MS Terminal, especially when the standard DA1 isn't available now hah😄

[e82eric]

yep, working on the mp4 now.

Quick update on the MS fix, I tried that branch without my changes, and the first attempt still tried to use chafa, I commented out this if statement and it correctly detected Sixel

yazi/yazi-adapter/src/adapter.rs

Line 95 in e940d81

protocols.retain(|p| *p == Self::Sixel);

. Maybe when the MS fix is merged that can be updated to just check for Tmux?

By the way, your project is awesome!

[sxyazi]

That's weird, this statement will only be entered if the ZELLIJ_SESSION_NAME env variable is detected:

yazi/yazi-adapter/src/adapter.rs

Lines 94 to 96 in e940d81

	if env_exists("ZELLIJ_SESSION_NAME") {
	protocols.retain(|p| *p == Self::Sixel);
	} else if *TMUX {

Are you running Yazi in Zellij?

[e82eric]

Not running it in Zellij, will try to step through it to see what was happening. I was thinking it removed Sixel from everything that wasn't Zellij.

How does this look?

terminal-sixel2.mp4

[sxyazi]

Looks great, thanks a lot!

[e82eric]

Quick update. it looks like it was just this line that needed to commented out. I think it is removing everything that isn't iterm2.

yazi/yazi-adapter/src/adapter.rs

Line 93 in e940d81

protocols.retain(|p| *p == Self::Iterm2);

[sxyazi]

Ah that makes sense, this is to ensure compatibility with third-party terminals that rely on the older version of ConPTY (like WezTerm and Mintty) for displaying images, so it still needs to be kept for now, and as time goes on and with OS updates, we can remove it in the future.

[e82eric]

That makes sense, side note, start time was back to 0 on the branch with the MS fix.

[sxyazi]

Thanks for testing, I've edited the content of this PR and added some notes about it