Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sveltekit search params #140

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Add sveltekit search params #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f774b4f
Add sveltekit-search-params to blog page
paoloricciuti Nov 30, 2022
81c78c8
Remove the if statement since the decode always return a value
paoloricciuti Nov 30, 2022
e3147d3
Remove unused import
paoloricciuti Nov 30, 2022
7e81e94
Update README.md
swyxio Nov 30, 2022
fa6ed63
Update README.md
swyxio Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 23 additions & 17 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,23 +49,29 @@ See https://swyxkit.netlify.app/ (see [Deploy Logs](https://app.netlify.com/site
- SvelteKit does not yet support [CSP](https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP) - [PR pending here](https://github.com/sveltejs/kit/pull/2394/files)
- [Builds and deploys in ~40 seconds on Netlify](https://app.netlify.com/sites/swyxkit/deploys)
- **Minor design/UX touches**
- `full`, `feature`, and `popout` [bleed layout](https://ryanmulligan.dev/blog/layout-breakouts/) classes on desktop - `feature` enabled by default for code samples! ([details and code samples here](https://swyxkit.netlify.app/layout-breakouts-in-swyxkit))
- Top level blog URLs (`/myblog` instead of `/blog/myblog` - [why](https://www.swyx.io/namespacing-sites/))
- Blog index truncates at 20 posts to make sure to render quickly
- Blog search/facets serialize to URLs for easy copy paste ([thanks @Ak4zh](https://github.com/sw-yx/swyxkit/pull/97))
- [Comments are rendered and sanitized](https://github.com/developit/snarkdown/issues/70)
- Error page (try going to URL that doesn't exist)
- Including nice error when GitHub API rate limit exceeded (fix by setting `GH_TOKEN`)
- The 404 page includes a link you can click that sends you back to the search index with the search terms ([blog post](https://github.com/sw-yx/swyxkit/issues/90))
- Navlink hover effect
- [Mobile/Responsive styling](https://swyxkit.netlify.app/mobileresponsive-styling-with-tailwind)
- Mobile menu with animation
- Og:image and meta tags for social unfurls (not automatically generated though)
- Accessibility
- SVG Icons https://github.com/sw-yx/spark-joy/blob/master/README.md#general--misc
- [Tap targets](https://web.dev/tap-targets/?utm_source=lighthouse&utm_medium=lr)
- Custom scrollbar https://css-tricks.com/strut-your-stuff-with-a-custom-scrollbar/
- Defensive CSS touches https://ishadeed.com/article/defensive-css
- Blog Index features
- Blog index truncates at 20 posts to make sure to render quickly
- Blog search/facets serialize to URLs for easy copy paste
- previously [done by @Ak4zh](https://github.com/sw-yx/swyxkit/pull/97)
- but since moved to [`sveltekit-search-params`](https://github.com/paoloricciuti/sveltekit-search-params) [by @paoloricciuti](https://github.com/sw-yx/swyxkit/pull/140)
- The Error page feature uses this to send you back to a searchable index
- Error page (try going to URL that doesn't exist)
- Including nice error when GitHub API rate limit exceeded (fix by setting `GH_TOKEN`)
- The 404 page includes a link you can click that sends you back to the search index with the search terms ([blog post](https://github.com/sw-yx/swyxkit/issues/90))
- Individual Blogpost features
- [Comments are rendered and sanitized](https://github.com/developit/snarkdown/issues/70)
- `full`, `feature`, and `popout` [bleed layout](https://ryanmulligan.dev/blog/layout-breakouts/) classes on desktop - `feature` enabled by default for code samples! ([details and code samples here](https://swyxkit.netlify.app/layout-breakouts-in-swyxkit))
- Top level blog URLs (`/myblog` instead of `/blog/myblog` - [why](https://www.swyx.io/namespacing-sites/))
- General features
- Navlink hover effect
- [Mobile/Responsive styling](https://swyxkit.netlify.app/mobileresponsive-styling-with-tailwind)
- Mobile menu with animation
- Og:image and meta tags for social unfurls (not automatically generated though)
- Accessibility
- SVG Icons https://github.com/sw-yx/spark-joy/blob/master/README.md#general--misc
- [Tap targets](https://web.dev/tap-targets/?utm_source=lighthouse&utm_medium=lr)
- Custom scrollbar https://css-tricks.com/strut-your-stuff-with-a-custom-scrollbar/
- Defensive CSS touches https://ishadeed.com/article/defensive-css
- **Developer Experience**
- [JSDoc Typechecking](https://swyxkit.netlify.app/how-to-add-jsdoc-typechecking-to-sveltekit)
- ESLint + Prettier
Expand Down
Loading