Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade default NodeJS version to v20 #547

Merged
merged 1 commit into from
Dec 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,12 @@ jobs:
statuses: write
steps:
- name: 👀 Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: true

- name: 👀 Checkout utils into subfolder
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false
repository: swrlab/node-utils
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
types: [labeled]

env:
NODE_VERSION: 18
NODE_VERSION: 20

jobs:
security:
Expand All @@ -22,17 +22,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: 👀 Checkout Code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: 🏗 Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
cache: "yarn"
cache-dependency-path: "**/yarn.lock"

- name: 📦 Install Yarn
run: corepack enable && yarn set version stable

- name: 📦 Install Dependencies
run: yarn
run: yarn install

- name: 🧪 Run Tests
run: yarn lint && yarn test
13 changes: 7 additions & 6 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,26 @@ on:
- main

env:
NODE_VERSION: 18
NODE_VERSION: 20

jobs:
test:
name: Run Mocha Tests
runs-on: ubuntu-latest
steps:
- name: 👀 Checkout Code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: 🏗 Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
cache: "yarn"
cache-dependency-path: "**/yarn.lock"

- name: 📦 Install Yarn
run: corepack enable && yarn set version stable

- name: 📦 Install Dependencies
run: yarn
run: yarn install

- name: 🧪 Run Tests
run: yarn lint && yarn test
10 changes: 8 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,14 @@ typings/
# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity
# https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
.yarn/
!**/.yarn/cache
!**/.yarn/patches
!**/.yarn/plugins
!**/.yarn/releases
!**/.yarn/sdks
!**/.yarn/versions

# next.js build output
.next
Expand Down
3 changes: 3 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
enableTelemetry: false

nodeLinker: node-modules
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ by [**SWR Audio Lab**](https://lab.swr.de/)

## Changelog

- 2023-12-18 - v1.2.0
- refact: optimize linter util to work with Yarn `>=v4`
- chore: upgrade default NodeJS version to `v20`

- 2023-04-19 - v1.1.3
- fix: don't run linter on dependabot-pr
- fix: use `toReadable` in `pluralize` helper
Expand Down
29 changes: 15 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@swrlab/utils",
"version": "1.1.3",
"version": "1.2.0",
"description": "Wrapping common SWR Audio Lab utils",
"main": "./index.js",
"engines": {
Expand All @@ -17,29 +17,30 @@
"ard:pub-sort": "node -r dotenv/config scripts/ard/sortPubByExtId.js",
"lint": "eslint .",
"test": "mocha tests/**.js -r dotenv/config",
"outdated": "yarn upgrade-interactive",
"reinstall": "rm -rf node_modules && rm yarn.lock && yarn"
},
"author": "SWR Audio Lab <lab@swr.de>",
"license": "MIT",
"private": false,
"dependencies": {
"@google-cloud/storage": "^6.11.0",
"@google-cloud/storage": "^6.12.0",
"abort-controller": "^3.0.0",
"aws-sdk": "^2.1395.0",
"chai": "^4.3.7",
"luxon": "^3.3.0",
"aws-sdk": "2.1520.0",
"luxon": "3.4.4",
"node-crc": "swrlab/node-crc#v2.1.0",
"undici": "^5.22.1",
"uuid": "9.0.0"
"undici": "6.0.1",
"uuid": "9.0.1"
},
"devDependencies": {
"@swrlab/eslint-plugin-swr": "^0.2.0",
"@swrlab/swr-prettier-config": "^0.2.0",
"dotenv": "^16.1.4",
"eslint": "^8.42.0",
"@swrlab/eslint-plugin-swr": "^0.3.0",
"@swrlab/swr-prettier-config": "^0.3.0",
"chai": "4.3.10",
"dotenv": "^16.3.1",
"eslint": "^8.56.0",
"eslint-plugin-json": "^3.1.0",
"mocha": "^10.2.0",
"prettier": "^2.8.8"
"prettier": "^3.1.1"
},
"prettier": "@swrlab/swr-prettier-config"
"prettier": "@swrlab/swr-prettier-config",
"packageManager": "yarn@4.0.2"
}
Loading
Loading