Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamming Window in ver.1.1.3 #44

Closed
unitay opened this issue Nov 16, 2021 · 1 comment · Fixed by #45
Closed

Hamming Window in ver.1.1.3 #44

unitay opened this issue Nov 16, 2021 · 1 comment · Fixed by #45

Comments

@unitay
Copy link

unitay commented Nov 16, 2021

Why Cosine, Hamming, Tukey and Welch windows is internal? Why Window.NormalizeInPlace is internal? How to use this in inherited class?
@swharden
Copy link
Owner

Hi @unitay,

Making those windows internal was not intentional. I'll make them public and issue a new release tonight.

I'm curious - what functionality are you adding by inheriting/extending these classes? These classes are pretty simple (e.g., Hamming.cs) so I'm interested in learning more about your use case.

swharden added a commit that referenced this issue Nov 17, 2021
@swharden
Window: make all windows public
18b147a 
resolves #44
@swharden swharden mentioned this issue Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Window: make all windows public swharden/FftSharp
2 participants
@unitay @swharden