Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(allocator): Feature gate nightly #9265

Closed
wants to merge 2 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 17, 2024

Description:

Feature gate nightly, and make it really identical to types from std if it's not enabled.

We need to use #[fundamental] for swc_allocator::boxed::Box. Without it, it will be very hard to use the type. But it's not stabilized. So we feature gate them under a cargo feature flag.

Related issue:

@kdy1 kdy1 requested a review from a team as a code owner July 17, 2024 08:24
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 17, 2024
@kdy1 kdy1 marked this pull request as draft July 17, 2024 08:24
@kdy1 kdy1 self-assigned this Jul 17, 2024
@kdy1 kdy1 added this to the Planned milestone Jul 17, 2024
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_allocator

@kdy1
Copy link
Member Author

kdy1 commented Jul 17, 2024

This was the wrong way. We may need to drop support for stable rustc

@kdy1 kdy1 closed this Jul 17, 2024
@kdy1 kdy1 deleted the allocator-rustc branch July 17, 2024 09:40
Copy link

codspeed-hq bot commented Jul 17, 2024

CodSpeed Performance Report

Merging #9265 will not alter performance

Comparing kdy1:allocator-rustc (9f1b217) with main (6ddbfa0)

Summary

✅ 178 untouched benchmarks

@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant