Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/lexer): Use memchr::memmem for lexing block comments #9096

Merged
merged 10 commits into from
Jun 22, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 22, 2024

Description:

This PR also makes the lexer more CPU-cache friendly.

@kdy1 kdy1 added this to the Planned milestone Jun 22, 2024
@kdy1 kdy1 self-assigned this Jun 22, 2024
@kdy1 kdy1 requested review from a team as code owners June 22, 2024 00:00
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 22, 2024
@kdy1 kdy1 enabled auto-merge (squash) June 22, 2024 00:00
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser
  • swc_core

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge June 22, 2024 00:54
@kdy1 kdy1 merged commit 1b3672f into swc-project:main Jun 22, 2024
147 checks passed
@kdy1 kdy1 deleted the pp branch June 22, 2024 00:54
@kdy1 kdy1 modified the milestones: Planned, v1.6.4 Jun 22, 2024
kdy1 added a commit that referenced this pull request Jul 1, 2024
kdy1 added a commit that referenced this pull request Jul 1, 2024
Reverts #9096.
I'm reverting this as this regressed performance in `linux-x86_64`.
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants