Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(es/utils): Refine some APIs #9049

Merged
merged 12 commits into from
Jun 14, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 14, 2024

Description:

This PR

  • moves some APIs into swc_ecma_ast.
  • removes needless types.

BREAKING CHANGE:

  • swc_ecma_utils::IdentExt::private => swc_ecma_ast::Ident::into_private.
  • swc_ecma_utils::IdentExt::prefix => swc_ecma_ast::Ident::with_prefix.
  • swc_ecma_utils::undefined => swc_ecma_ast::Expr::undefined.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jun 14, 2024
@kdy1 kdy1 self-assigned this Jun 14, 2024
@kdy1 kdy1 force-pushed the util-refactor branch 2 times, most recently from df7093d to dea108b Compare June 14, 2024 05:44
@kdy1 kdy1 marked this pull request as ready for review June 14, 2024 06:03
@kdy1 kdy1 requested review from a team as code owners June 14, 2024 06:03
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 14, 2024
@kdy1 kdy1 enabled auto-merge (squash) June 14, 2024 06:03
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 14, 2024
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_ast --breaking

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge June 14, 2024 12:53
@kdy1 kdy1 merged commit e856478 into swc-project:main Jun 14, 2024
146 of 148 checks passed
@kdy1 kdy1 deleted the util-refactor branch June 14, 2024 12:53
@kdy1 kdy1 modified the milestones: Planned, v1.6.0 Jun 16, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants