Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(visit): Pre-generate visitor code #9262

Merged
merged 214 commits into from
Jul 17, 2024
Merged

refactor(visit): Pre-generate visitor code #9262

merged 214 commits into from
Jul 17, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 16, 2024 •
edited
Loading

Description:

This would improve compile time by a margin, and this is a refactoring that should be done before applying swc_allocator::boxed::Box to ES AST.

This PR removes swc_visit_macros because we now use a simple binary to generate code before publishing.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jul 16, 2024
@kdy1 kdy1 self-assigned this Jul 16, 2024
@kdy1 kdy1 changed the title refactor(visit): Pre-generated visitor code refactor(visit): Pre-generate visitor code Jul 16, 2024
This was referenced Jul 16, 2024
Open
Closed
@kdy1 kdy1 marked this pull request as ready for review July 17, 2024 21:06
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 17, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) July 17, 2024 21:06
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 17, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 17, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 17, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 17, 2024
View reviewed changes
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9262 will not alter performance

Comparing kdy1:codegen (3f76bea) with kdy1:codegen (15ecdc3)

Summary

✅ 178 untouched benchmarks

@kdy1 kdy1 merged commit 9c17663 into swc-project:main Jul 17, 2024
156 checks passed
@kdy1 kdy1 deleted the codegen branch July 17, 2024 23:00
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 18, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Open
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Publish pre-codegened version of AST/visitor crates
2 participants
@kdy1 @swc-bot