Skip to content

Commit

Permalink
fix(ci): Restore disabled CI checks (#9002)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kdy1
kdy1 committed Jul 4, 2024
1 parent 97e3ba2 commit cdfd4c8
Showing 1 changed file with 50 additions and 47 deletions.
97 changes: 50 additions & 47 deletions .github/workflows/publish-core.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Publish (core)

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ github.event_name != 'push' }}
cancel-in-progress: true

env:
DEBUG: napi:*
Expand Down Expand Up @@ -202,6 +202,7 @@ jobs:
options: -v ${{ env.HOME }}/.cargo/git:/root/.cargo/git -v ${{ env.HOME }}/.cargo/registry:/root/.cargo/registry -v ${{ github.workspace }}:/build -w /build
run: >-
cd ./packages/core &&
npm install -f -g yarn@1.22.19 &&
corepack enable &&
npm i -g wasm-pack &&
${{ matrix.settings.build }}
Expand Down Expand Up @@ -232,7 +233,7 @@ jobs:
target: x86_64-apple-darwin
node:
- "18"
# - "20"
- "20"
runs-on: ${{ matrix.settings.host }}
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -270,7 +271,7 @@ jobs:
matrix:
node:
- "18"
# - "20"
- "20"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -294,7 +295,7 @@ jobs:
- name: Build TypeScript
run: yarn build:ts
- name: Test bindings
run: docker run --rm -v $(pwd):/swc -w /swc node:${{ matrix.node }}-slim env DISABLE_PLUGIN_E2E_TESTS=true yarn test
run: docker run --rm -v $(pwd):/swc -w /swc node:${{ matrix.node }}-slim sh -c 'npm install -f -g yarn@1.22.19 && env DISABLE_PLUGIN_E2E_TESTS=true yarn test'
test-linux-x64-musl-binding:
if: ${{ startsWith(github.ref, 'refs/tags/v') || startsWith(github.ref, 'refs/heads/ci') }}
name: Test bindings on x86_64-unknown-linux-musl - node@${{ matrix.node }}
Expand All @@ -305,7 +306,7 @@ jobs:
matrix:
node:
- "18"
# - "20"
- "20"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -332,46 +333,47 @@ jobs:
- name: Build TypeScript
run: yarn build:ts
- name: Test bindings
run: docker run --rm -v $(pwd):/swc -w /swc node:${{ matrix.node }}-alpine env DISABLE_PLUGIN_E2E_TESTS=true yarn test
# test-linux-aarch64-musl-binding:
# if: ${{ startsWith(github.ref, 'refs/tags/v') || startsWith(github.ref, 'refs/heads/ci') }}
# name: Test bindings on aarch64-unknown-linux-musl - node@lts
# needs:
# - build
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - name: Corepack
# run: corepack enable
# - name: Download artifacts
# uses: actions/download-artifact@v3
# with:
# name: bindings-aarch64-unknown-linux-musl
# path: ./packages/core
# - name: List packages
# run: ls -R .
# shell: bash
# - name: Install dependencies
# run: |
# corepack enable
# yarn config set supportedArchitectures.cpu "arm64"
# yarn config set supportedArchitectures.libc "musl"
# yarn install
# - name: Build TypeScript
# run: yarn build:ts
# - name: Set up QEMU
# uses: docker/setup-qemu-action@v2
# with:
# platforms: arm64
# - run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
# - name: Setup and run tests
# uses: addnab/docker-run-action@v3
# with:
# image: node:lts-alpine
# options: "--platform linux/arm64 -v ${{ github.workspace }}:/build -w /build"
# run: >-
# set -e &&
# DISABLE_PLUGIN_E2E_TESTS=true yarn test
run: docker run --rm -v $(pwd):/swc -w /swc node:${{ matrix.node }}-alpine sh -c 'npm install -f -g yarn@1.22.19 && env DISABLE_PLUGIN_E2E_TESTS=true yarn test'
test-linux-aarch64-musl-binding:
if: ${{ startsWith(github.ref, 'refs/tags/v') || startsWith(github.ref, 'refs/heads/ci') }}
name: Test bindings on aarch64-unknown-linux-musl - node@lts
needs:
- build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Corepack
run: corepack enable
- name: Download artifacts
uses: actions/download-artifact@v3
with:
name: bindings-aarch64-unknown-linux-musl
path: ./packages/core
- name: List packages
run: ls -R .
shell: bash
- name: Install dependencies
run: |
corepack enable
yarn config set supportedArchitectures.cpu "arm64"
yarn config set supportedArchitectures.libc "musl"
yarn install
- name: Build TypeScript
run: yarn build:ts
- name: Set up QEMU
uses: docker/setup-qemu-action@v2
with:
platforms: arm64
- run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
- name: Setup and run tests
uses: addnab/docker-run-action@v3
with:
image: node:lts-alpine
options: "--platform linux/arm64 -v ${{ github.workspace }}:/build -w /build"
run: >-
set -e &&
npm install -f -g yarn@1.22.19 &&
DISABLE_PLUGIN_E2E_TESTS=true yarn test
test-linux-arm-gnueabihf-binding:
if: ${{ startsWith(github.ref, 'refs/tags/v') || startsWith(github.ref, 'refs/heads/ci') }}
Expand All @@ -383,7 +385,7 @@ jobs:
matrix:
node:
- "18"
# - "20"
- "20"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -416,6 +418,7 @@ jobs:
options: "--platform linux/arm/v7 -v ${{ github.workspace }}:/build -w /build"
run: >-
set -e &&
npm install -f -g yarn@1.22.19 &&
DISABLE_PLUGIN_E2E_TESTS=true yarn test &&
ls -la
publish:
Expand All @@ -426,7 +429,7 @@ jobs:
- test-linux-x64-musl-binding
- test-linux-arm-gnueabihf-binding
- test-macOS-windows-binding
# - test-linux-aarch64-musl-binding
- test-linux-aarch64-musl-binding
steps:
- uses: actions/checkout@v4

Expand Down

1 comment on commit cdfd4c8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: cdfd4c8 Previous: c6d6db3 Ratio
es/full/bugs-1 296626 ns/iter (± 13302) 291711 ns/iter (± 7351) 1.02
es/full/minify/libraries/antd 1935191488 ns/iter (± 56780884) 1805953667 ns/iter (± 84758697) 1.07
es/full/minify/libraries/d3 355936101 ns/iter (± 4245658) 349549990 ns/iter (± 9993807) 1.02
es/full/minify/libraries/echarts 1617828707 ns/iter (± 25637561) 1523995820 ns/iter (± 42340439) 1.06
es/full/minify/libraries/jquery 104382568 ns/iter (± 536013) 104324436 ns/iter (± 1131651) 1.00
es/full/minify/libraries/lodash 115645657 ns/iter (± 504197) 115222432 ns/iter (± 689340) 1.00
es/full/minify/libraries/moment 60138308 ns/iter (± 275476) 61684699 ns/iter (± 467136) 0.97
es/full/minify/libraries/react 18448010 ns/iter (± 162967) 19055633 ns/iter (± 77705) 0.97
es/full/minify/libraries/terser 284977711 ns/iter (± 2586392) 329985348 ns/iter (± 4836528) 0.86
es/full/minify/libraries/three 500703204 ns/iter (± 26662908) 607664243 ns/iter (± 21021281) 0.82
es/full/minify/libraries/typescript 3379233115 ns/iter (± 37444297) 3320036783 ns/iter (± 50453410) 1.02
es/full/minify/libraries/victory 835350900 ns/iter (± 14999955) 743172517 ns/iter (± 12018993) 1.12
es/full/minify/libraries/vue 148081221 ns/iter (± 1965547) 149671475 ns/iter (± 771372) 0.99
es/full/codegen/es3 60472 ns/iter (± 617) 61642 ns/iter (± 391) 0.98
es/full/codegen/es5 60396 ns/iter (± 441) 61825 ns/iter (± 312) 0.98
es/full/codegen/es2015 60290 ns/iter (± 398) 61506 ns/iter (± 250) 0.98
es/full/codegen/es2016 59962 ns/iter (± 179) 61430 ns/iter (± 316) 0.98
es/full/codegen/es2017 60367 ns/iter (± 332) 61809 ns/iter (± 313) 0.98
es/full/codegen/es2018 60150 ns/iter (± 327) 61480 ns/iter (± 205) 0.98
es/full/codegen/es2019 60320 ns/iter (± 454) 61815 ns/iter (± 289) 0.98
es/full/codegen/es2020 60173 ns/iter (± 102) 61505 ns/iter (± 171) 0.98
es/full/all/es3 162768145 ns/iter (± 1757369) 160731563 ns/iter (± 779089) 1.01
es/full/all/es5 157162582 ns/iter (± 1175415) 154938165 ns/iter (± 1436925) 1.01
es/full/all/es2015 115790656 ns/iter (± 997736) 114445101 ns/iter (± 1508768) 1.01
es/full/all/es2016 113887454 ns/iter (± 794358) 113026235 ns/iter (± 625883) 1.01
es/full/all/es2017 113592648 ns/iter (± 501691) 112989868 ns/iter (± 1894266) 1.01
es/full/all/es2018 112412408 ns/iter (± 689105) 110989883 ns/iter (± 751677) 1.01
es/full/all/es2019 111567568 ns/iter (± 1025963) 110594997 ns/iter (± 361095) 1.01
es/full/all/es2020 107942481 ns/iter (± 500084) 106589737 ns/iter (± 1217622) 1.01
es/full/parser 455462 ns/iter (± 1869) 451087 ns/iter (± 2050) 1.01
es/full/base/fixer 15392 ns/iter (± 79) 15313 ns/iter (± 125) 1.01
es/full/base/resolver_and_hygiene 80347 ns/iter (± 164) 80866 ns/iter (± 407) 0.99
serialization of serde 272 ns/iter (± 2) 263 ns/iter (± 6) 1.03
css/minify/libraries/bootstrap 21711656 ns/iter (± 371387) 23045467 ns/iter (± 58685) 0.94
css/visitor/compare/clone 1351472 ns/iter (± 6424) 1391863 ns/iter (± 28144) 0.97
css/visitor/compare/visit_mut_span 1480888 ns/iter (± 18368) 1518309 ns/iter (± 9026) 0.98
css/visitor/compare/visit_mut_span_panic 1499730 ns/iter (± 17639) 1550361 ns/iter (± 29054) 0.97
css/visitor/compare/fold_span 1986734 ns/iter (± 5649) 2032196 ns/iter (± 54543) 0.98
css/visitor/compare/fold_span_panic 2122084 ns/iter (± 6008) 2254965 ns/iter (± 38917) 0.94
css/lexer/bootstrap_5_1_3 3615624 ns/iter (± 6416) 3447449 ns/iter (± 3561) 1.05
css/lexer/foundation_6_7_4 2851903 ns/iter (± 4545) 2784479 ns/iter (± 1786) 1.02
css/lexer/tailwind_3_1_1 546006 ns/iter (± 410) 536800 ns/iter (± 1005) 1.02
css/parser/bootstrap_5_1_3 15929312 ns/iter (± 68976) 16675684 ns/iter (± 193077) 0.96
css/parser/foundation_6_7_4 12727460 ns/iter (± 96611) 13301828 ns/iter (± 120672) 0.96
css/parser/tailwind_3_1_1 2505052 ns/iter (± 13119) 2540260 ns/iter (± 20199) 0.99
es/codegen/colors 722919 ns/iter (± 395051) 724498 ns/iter (± 395220) 1.00
es/codegen/large 2957380 ns/iter (± 1610580) 2954037 ns/iter (± 1576070) 1.00
es/codegen/with-parser/colors 40015 ns/iter (± 239) 40263 ns/iter (± 589) 0.99
es/codegen/with-parser/large 448845 ns/iter (± 1539) 447756 ns/iter (± 11520) 1.00
es/minify/libraries/antd 1616736734 ns/iter (± 46120028) 1422161603 ns/iter (± 23048737) 1.14
es/minify/libraries/d3 340989071 ns/iter (± 11574318) 281246306 ns/iter (± 1075581) 1.21
es/minify/libraries/echarts 1333116249 ns/iter (± 33687227) 1141508402 ns/iter (± 11748302) 1.17
es/minify/libraries/jquery 84867058 ns/iter (± 527849) 82456586 ns/iter (± 277607) 1.03
es/minify/libraries/lodash 106796139 ns/iter (± 1313270) 104347537 ns/iter (± 242306) 1.02
es/minify/libraries/moment 49724131 ns/iter (± 311655) 48317666 ns/iter (± 167750) 1.03
es/minify/libraries/react 16484171 ns/iter (± 54888) 16223778 ns/iter (± 12313) 1.02
es/minify/libraries/terser 240340468 ns/iter (± 7334971) 216743732 ns/iter (± 625518) 1.11
es/minify/libraries/three 381182943 ns/iter (± 10378125) 360358753 ns/iter (± 3117883) 1.06
es/minify/libraries/typescript 2837740276 ns/iter (± 15053269) 2711641352 ns/iter (± 24721039) 1.05
es/minify/libraries/victory 624722817 ns/iter (± 31696433) 561586712 ns/iter (± 5231270) 1.11
es/minify/libraries/vue 121871260 ns/iter (± 1118815) 120808843 ns/iter (± 374035) 1.01
es/visitor/compare/clone 1703918 ns/iter (± 3588) 1707148 ns/iter (± 7815) 1.00
es/visitor/compare/visit_mut_span 2050387 ns/iter (± 17363) 2049958 ns/iter (± 12369) 1.00
es/visitor/compare/visit_mut_span_panic 2049055 ns/iter (± 33935) 2047803 ns/iter (± 52641) 1.00
es/visitor/compare/fold_span 2767744 ns/iter (± 12279) 2777711 ns/iter (± 6751) 1.00
es/visitor/compare/fold_span_panic 2818029 ns/iter (± 33307) 2804818 ns/iter (± 8888) 1.00
es/lexer/colors 9387 ns/iter (± 27) 9480 ns/iter (± 85) 0.99
es/lexer/angular 4915170 ns/iter (± 24931) 4913368 ns/iter (± 68772) 1.00
es/lexer/backbone 640267 ns/iter (± 1661) 647451 ns/iter (± 2033) 0.99
es/lexer/jquery 3641539 ns/iter (± 10743) 3750257 ns/iter (± 21936) 0.97
es/lexer/jquery mobile 5457136 ns/iter (± 13868) 5278639 ns/iter (± 118597) 1.03
es/lexer/mootools 2810465 ns/iter (± 4424) 2829153 ns/iter (± 6290) 0.99
es/lexer/underscore 523443 ns/iter (± 3797) 541301 ns/iter (± 1481) 0.97
es/lexer/three 16416797 ns/iter (± 73078) 16057144 ns/iter (± 48678) 1.02
es/lexer/yui 3065214 ns/iter (± 10629) 3044275 ns/iter (± 32337) 1.01
es/lexer/cal-com 13372914 ns/iter (± 100912) 13292557 ns/iter (± 107050) 1.01
es/lexer/typescript 90568198 ns/iter (± 115011) 93590774 ns/iter (± 834164) 0.97
es/parser/colors 23688 ns/iter (± 160) 23520 ns/iter (± 112) 1.01
es/parser/angular 12453315 ns/iter (± 94256) 12596460 ns/iter (± 180045) 0.99
es/parser/backbone 1812956 ns/iter (± 6530) 1830334 ns/iter (± 17557) 0.99
es/parser/jquery 9991370 ns/iter (± 52140) 10107657 ns/iter (± 82501) 0.99
es/parser/jquery mobile 15190434 ns/iter (± 115847) 15408520 ns/iter (± 241218) 0.99
es/parser/mootools 7804252 ns/iter (± 14334) 7846023 ns/iter (± 22427) 0.99
es/parser/underscore 1589830 ns/iter (± 5043) 1601277 ns/iter (± 6686) 0.99
es/parser/three 44400225 ns/iter (± 1174536) 45373379 ns/iter (± 791117) 0.98
es/parser/yui 7449999 ns/iter (± 35010) 7453951 ns/iter (± 27211) 1.00
es/parser/cal-com 39303468 ns/iter (± 282200) 41592419 ns/iter (± 544089) 0.94
es/parser/typescript 267045587 ns/iter (± 1099650) 271659978 ns/iter (± 1697016) 0.98
es/preset-env/usage/builtin_type 136165 ns/iter (± 34670) 137201 ns/iter (± 33895) 0.99
es/preset-env/usage/property 16873 ns/iter (± 68) 16366 ns/iter (± 78) 1.03
es/resolver/typescript 97306424 ns/iter (± 2104535) 98785136 ns/iter (± 2193785) 0.99
es/fixer/typescript 78201439 ns/iter (± 2458382) 77924761 ns/iter (± 4141923) 1.00
es/hygiene/typescript 180595481 ns/iter (± 4352750) 183575176 ns/iter (± 3244170) 0.98
es/resolver_with_hygiene/typescript 300731899 ns/iter (± 3867950) 303635285 ns/iter (± 6617988) 0.99
es/visitor/base-perf/module_clone 56204 ns/iter (± 538) 55979 ns/iter (± 398) 1.00
es/visitor/base-perf/fold_empty 59351 ns/iter (± 500) 59513 ns/iter (± 914) 1.00
es/visitor/base-perf/fold_noop_impl_all 58909 ns/iter (± 1321) 59819 ns/iter (± 860) 0.98
es/visitor/base-perf/fold_noop_impl_vec 59422 ns/iter (± 851) 60156 ns/iter (± 1079) 0.99
es/visitor/base-perf/boxing_boxed_clone 61 ns/iter (± 0) 60 ns/iter (± 0) 1.02
es/visitor/base-perf/boxing_unboxed_clone 47 ns/iter (± 0) 47 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 108 ns/iter (± 0) 105 ns/iter (± 0) 1.03
es/visitor/base-perf/boxing_unboxed 79 ns/iter (± 0) 81 ns/iter (± 0) 0.98
es/visitor/base-perf/visit_contains_this 2586 ns/iter (± 13) 2642 ns/iter (± 35) 0.98
es/base/parallel/resolver/typescript 2397800715 ns/iter (± 138299674) 2300766543 ns/iter (± 149922368) 1.04
es/base/parallel/hygiene/typescript 3195517521 ns/iter (± 39765097) 3219487164 ns/iter (± 48151573) 0.99
babelify-only 485611 ns/iter (± 11577) 494374 ns/iter (± 17605) 0.98
parse_and_babelify_angular 42459253 ns/iter (± 2453885) 42378886 ns/iter (± 709520) 1.00
parse_and_babelify_backbone 4449316 ns/iter (± 197533) 4377755 ns/iter (± 56767) 1.02
parse_and_babelify_jquery 29468033 ns/iter (± 352234) 28442861 ns/iter (± 380635) 1.04
parse_and_babelify_jquery_mobile 51892515 ns/iter (± 1018380) 50286844 ns/iter (± 802010) 1.03
parse_and_babelify_mootools 26871744 ns/iter (± 514589) 25647772 ns/iter (± 188285) 1.05
parse_and_babelify_underscore 3695789 ns/iter (± 16068) 3715512 ns/iter (± 11606) 0.99
parse_and_babelify_yui 25572489 ns/iter (± 1094911) 23834010 ns/iter (± 851302) 1.07
html/minify/document/css_spec 45136124 ns/iter (± 267217) 46794606 ns/iter (± 278661) 0.96
html/minify/document/github 17990239 ns/iter (± 72604) 18544186 ns/iter (± 185813) 0.97
html/minify/document/stackoverflow 16466957 ns/iter (± 468888) 16731014 ns/iter (± 325887) 0.98
html/minify/document_fragment/css_spec 44941928 ns/iter (± 207118) 44736192 ns/iter (± 350183) 1.00
html/minify/document_fragment/github 17808203 ns/iter (± 64804) 17946492 ns/iter (± 139044) 0.99
html/minify/document_fragment/stackoverflow 16424957 ns/iter (± 115084) 16652246 ns/iter (± 58685) 0.99
html/document/visitor/compare/clone 167527 ns/iter (± 2006) 167797 ns/iter (± 1918) 1.00
html/document/visitor/compare/visit_mut_span 183689 ns/iter (± 1386) 181835 ns/iter (± 699) 1.01
html/document/visitor/compare/visit_mut_span_panic 188336 ns/iter (± 7489) 191305 ns/iter (± 6444) 0.98
html/document/visitor/compare/fold_span 233731 ns/iter (± 1368) 227185 ns/iter (± 1908) 1.03
html/document/visitor/compare/fold_span_panic 282118 ns/iter (± 772) 283535 ns/iter (± 1780) 1.00
html/document_fragment/visitor/compare/clone 168996 ns/iter (± 937) 168588 ns/iter (± 554) 1.00
html/document_fragment/visitor/compare/visit_mut_span 183895 ns/iter (± 1279) 184205 ns/iter (± 1134) 1.00
html/document_fragment/visitor/compare/visit_mut_span_panic 188596 ns/iter (± 1249) 187872 ns/iter (± 1405) 1.00
html/document_fragment/visitor/compare/fold_span 231341 ns/iter (± 1416) 229698 ns/iter (± 1195) 1.01
html/document_fragment/visitor/compare/fold_span_panic 280894 ns/iter (± 762) 280877 ns/iter (± 1957) 1.00
html/lexer/css_2021_spec 12851674 ns/iter (± 12918) 12820021 ns/iter (± 30222) 1.00
html/lexer/github_com_17_05_2022 4917875 ns/iter (± 14984) 4915079 ns/iter (± 34333) 1.00
html/lexer/stackoverflow_com_17_05_2022 4718122 ns/iter (± 11086) 4668399 ns/iter (± 29563) 1.01
html/parser/parser_document/css_2021_spec 25804485 ns/iter (± 79011) 25979649 ns/iter (± 170288) 0.99
html/parser/parser_document/github_com_17_05_2022 8546676 ns/iter (± 12593) 8487959 ns/iter (± 219225) 1.01
html/parser/parser_document/stackoverflow_com_17_05_2022 7547577 ns/iter (± 23267) 7475187 ns/iter (± 162307) 1.01
html/parser/parser_document_fragment/css_2021_spec 25619810 ns/iter (± 79944) 25249337 ns/iter (± 43584) 1.01
html/parser/parser_document_fragment/github_com_17_05_2022 8489741 ns/iter (± 33759) 8436042 ns/iter (± 11499) 1.01
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7457978 ns/iter (± 22761) 7403625 ns/iter (± 29885) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.