fix(es/minifier): Fix name mangler (#9524)

swc-project · Sep 2, 2024 · 5fd68f9 · 5fd68f9
1 parent 595e8db
commit 5fd68f9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/.changeset/gentle-coats-tie.md b/.changeset/gentle-coats-tie.md
@@ -0,0 +1,6 @@
+---
+swc_core: patch
+swc_ecma_minifier: patch
+---
+
+fix(es/minifier): Fix name mangler
diff --git a/crates/swc_ecma_minifier/src/pass/mangle_names/mod.rs b/crates/swc_ecma_minifier/src/pass/mangle_names/mod.rs
@@ -35,11 +35,12 @@ pub(crate) fn mangle_names(
         chars,
     ));
 
-    let mut cache = RenameMap::default();
+    let mut cache = None;
 
     if let Some(mangle_cache) = &mangle_name_cache {
-        mangle_cache
-            .vars_cache(&mut |v| cache.extend(v.iter().map(|(k, v)| (k.clone(), v.clone()))));
+        let mut c = RenameMap::default();
+        mangle_cache.vars_cache(&mut |v| c.extend(v.iter().map(|(k, v)| (k.clone(), v.clone()))));
+        cache = Some(c);
     }
 
     program.visit_mut_with(&mut renamer(
@@ -61,7 +62,7 @@ pub(crate) fn mangle_names(
 struct ManglingRenamer {
     chars: Base54Chars,
     preserved: FxHashSet<Id>,
-    cache: RenameMap,
+    cache: Option<RenameMap>,
     mangle_name_cache: Option<Arc<dyn MangleCache>>,
 }
 
@@ -82,7 +83,7 @@ impl Renamer for ManglingRenamer {
     }
 
     fn get_cached(&self) -> Option<Cow<RenameMap>> {
-        Some(Cow::Borrowed(&self.cache))
+        self.cache.as_ref().map(Cow::Borrowed)
     }
 
     fn store_cache(&mut self, update: &RenameMap) {