-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/7232 multiple wrap components #7236
Feature/7232 multiple wrap components #7236
Conversation
…ore components, This commit provides a backward compatible mechanism
@DayS Thanks for the PR, it looks good in general, and thanks for considering possibly breaking changes. A couple of feedback points:
By adding If you have any additional questions or thoughts, please feel free to share. Thanks again! |
Hi, thanks for the review. The And just to be sure :
You mean |
I tend to favor verbosity. 😄
correct. typo. |
The PR has been updates with the changes. Let me know if it seems clear enough for the doc changes |
@DayS PR merged! Thanks for the collaboration and contribution! |
Awesome ! You're welcome. I'm thrilling to see the next release and use this :) |
This PR fixes the issue #7232 : Adding multiple plugins with wrapComponents on the same core component seems broken
A new option
pluginsBehavior
has been added to keep backward compatibility for existing plugins.When this flag is set to
chain
, thesystem.combinePlugins()
method chain the plugins targeting the same core component, by providing the system to innersystemExtend
call.Motivation and Context
I'm currently working on a set of plugins and stumble upon this issue as multiple of them needed to wrap
info
component.Also, I think the project lacks some unique plug-points (like the
JumpToPath
which is used in multiple context).Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests