Encode slashes in path parameters

[gwicke]

Slashes in path parameters should be encoded in order to produce valid URLs.

Fixes: #1013

[mohsen1]

This can be done with a much simpler approach:

return pathParam.toString().split('/').map(encodeURIComponent).join('/')

Please update the code and and add test if possible.

[gwicke]

The point is to encode slashes as well.

[fehguy]

Two thoughts. First, this is in the underlying javascript library, swagger-js. The PR would really belong there.

Second, we have been back and forth on how this should work. Some people want to support slashes in the param and some want them encoded. The current code intentionally supports slashes so "splat" params are valid. I'm not sure what the right answer is other than to make it configurable because there's no one way to do it.

[gwicke]

@fehguy, IMHO the current encoding code is just a hacky and inconsistent way to work around the lack of level 2 URI templates. The encoding path pretends that parameters were actually specified as {+splat_param}, while according to the spec they are actually just {single_path_component}s. This patch makes the encoding path consistent with the current swagger spec 2.0.

I hope that proper RFC 6570 support will make its way into the 2.1 spec, so that {+splat_path} can be used to encode "splat" paths where they are actually desired, without breaking the encoding semantics for {single_path_component}.

[gwicke]

Created another PR against swagger-js at swagger-api/swagger-js#280.

[gwicke]

See also: OAI/OpenAPI-Specification#93

[mohsen1]

Closing in favor of swagger-api/swagger-js#280