Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAVEN PLUGIN] Checking for null configOptions before looking for property #7613

Merged
merged 2 commits into from
Feb 10, 2018
Merged

[MAVEN PLUGIN] Checking for null configOptions before looking for property #7613

merged 2 commits into from
Feb 10, 2018

Conversation

matthewmcgarvey
Copy link
Contributor

Description of the PR

Issue #7612

Checks if configOptions is null before checking if it has a property

@wing328
Copy link
Contributor

wing328 commented Feb 8, 2018

@matthewmcgarvey thanks for the PR.

What about putting the code inside the if block without adding configOptionsNotNullAndContainsKey?

@matthewmcgarvey
Copy link
Contributor Author

@wing328 I inlined the method calls but it wouldn't go inside that if block because the properties should be applied if configOptions is null as well as when the properties aren't on configOptions.
I was negating configOptionsNotNullAndContainsKey in all instances I was using it which could have been confusing.

@wing328
Copy link
Contributor

wing328 commented Feb 10, 2018

@matthewmcgarvey ah now I understand what you're trying to fix 👍

@wing328 wing328 merged commit 0a28aad into swagger-api:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants