[Java/Feign] Don't HTML escape Accept / Content-Type header #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When e.g. the Accept-Header contains special characters such as `=`, mustache escapes them, which results in code like this to be generated:
```java
// MyApi.java
public interface MyApi extends ApiClient.Api {
@RequestLine("GET /rest/protected/items?size={size}&page={page}")
@headers({
"Content-Type: */*",
"Accept: application/com.example+json; version=1.0; charset=utf-8,application/com.example+xml; version=1.0; charset=utf-8,application/json; charset=utf-8,application/xml; charset=utf-8",
})
LicenseListResource getLicenses(@QueryMap(encoded=true) Map<String, Object> queryParams);
}
```
Note the `Accept: application/com.example+json; version=1.0; charset=utf-8` with the escaped `=`, which does not work. This disables HTML escaping for the header values.
On a side note though, I had been wondering whether HTML escaping makes sense when generating Java files? It does in JavaDocs I suppose, but shouldn't it be disabled everywhere else?
|
thanks @blutorange ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When e.g. the Accept-Header contains special characters such as
=, mustache escapes them, which results in code like this to be generated:Note the
Accept: application/com.example+json; version=1.0; charset=utf-8with the escaped=, which does not work. This disables HTML escaping for the header values.On a side note though, I had been wondering whether HTML escaping makes sense when generating Java files? It does in JavaDocs I suppose, but shouldn't it be disabled everywhere else?