dev(components): hide inaccessible projects in component summary #808
Conversation
| Set<String> searchIds = queryForIdsAsValue("byreleaseid", id); | ||
|
|
||
| return new HashSet<>((makeSummaryFromFullDocs(SummaryType.SHORT, filterAccessibleProjectsByIds(user, searchIds)))); | ||
| Set<String> ids = new HashSet<>(Arrays.asList(id)); |
| @@ -760,19 +761,21 @@ private void prepareDetailView(RenderRequest request, RenderResponse response) { | |||
| private void setUsingDocs(RenderRequest request, User user, ComponentService.Iface client, Set<String> releaseIds) { | |||
| Set<Project> usingProjects = null; | |||
| Set<Component> usingComponentsForComponent = null; | |||
| int allUsingProjectsCount = -1; | |||
There was a problem hiding this comment.
Why is -1 the fallback, instead of 0?
There was a problem hiding this comment.
instead of using -1 as fallback one could only fill it after line 769, i.e. if the call was successful
There was a problem hiding this comment.
Oh, now I see https://github.com/sw360/sw360portal/pull/808/files#diff-e8bd4c4dc1849fc1be46b0781739dcd5R13. I think that this is not the nicest way of handling exceptions.
There was a problem hiding this comment.
usingProjectTable evalutes the value of allUsingProjectsCount.
You are right, its not the best way of handling exceptions.
setUsingDocs should throw the exception instead of only logging it.
But I dont want to refactor this method here.
maierthomas
force-pushed
the
dev/805-using-projects-summary
branch
from
ee58880
to
25bd3c9
Compare
maierthomas
force-pushed
the
dev/805-using-projects-summary
branch
2 times, most recently
from
ee49114
to
0f02cf4
Compare
|
tested-by:michael.c.jaeger@siemens.com |
maierthomas
force-pushed
the
dev/805-using-projects-summary
branch
5 times, most recently
from
26f0a50
to
0454cbd
Compare
|
@mcjaeger updated branch again,
|
maierthomas
force-pushed
the
dev/805-using-projects-summary
branch
3 times, most recently
from
bdc2a3c
to
61963d9
Compare
- hide inaccessible projects in the "is used by the following" section - add usage count of linked projects
maierthomas
force-pushed
the
dev/805-using-projects-summary
branch
from
61963d9
to
4fc3300
Compare
|
tested successfully on local and siemens test instance |
allUsingProjectsCount)closes #805