This repository has been archived by the owner on Jul 25, 2018. It is now read-only.
Excel export extended by releases #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(type == SummaryType.DETAILED_EXPORT_SUMMARY){ | ||
| setDetailedExportSummaryFields(document, copy); | ||
| } else { | ||
| copyField(document, copy, _Fields.ID); |
There was a problem hiding this comment.
This could be moved to a verbosly named function
There was a problem hiding this comment.
This is just a
listOfFields.stream()
.forEach(renderedField -> copyField(document, copy, renderedField));
There was a problem hiding this comment.
Did the first one, but not the second.
| try { | ||
| projects = projectClient.getProjectsById(ids, user); | ||
| } catch (TException e) { | ||
| log.error("Error fetching linked projects.", e); |
There was a problem hiding this comment.
Same as above: this should fail hard
|
Done with refactoring from my side. Is it enough? |
|
Yes, code looks good. |
* one line per project - linked release combination * only directly linked releases * more fields exported (almost all)
* vendor, ClearingInfo, COTSDetails in separate columns * possibility to select whether linked releases are exported with the project * names instead of couchDB ids for linked projects and linked releases * excelExport for project respects filter
* selectable with or without releases * respects filters (but not keyword search) * more component fields exported
* prevents differences between excel export and view * button is automatically enabled as soon as page is refreshed by "Apply Filters" or "enter" on an input
heydenreich
force-pushed
the
dev/projectExcelExport
branch
from
ec17300
to
1c1f30e
Compare
mcjaeger
approved these changes
Sep 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects and components: closes #223