Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open hyperlinks in the built-in markdown preview #481

Closed
SuperSASS opened this issue Nov 5, 2021 · 5 comments
Closed

Can't open hyperlinks in the built-in markdown preview #481

SuperSASS opened this issue Nov 5, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@SuperSASS
Copy link

When I click the hyperlink of [[link]] in the built-in VSCode Markdown preview, it can't be opened because the path of linked file is wrong, as the working directory will be added to the front of the path.

For example:

1

After I click the hyperlink "Tips" in markdown preview, an error will pop up.

2

You can find the additional working directory as the underlined part.

  • OS: Windows 10 21H1 (The same problem happened in Windows 7, either)
  • VSCode version: 1.62.0

I have disabled all extensions for markdown but the problem still remains.


However, I found it works fine on my Linux system.

linux_welldone

Moreover, I found if I use ![[link]] and click the hyperlink icon on the right, it will open the browser with the address: https://file+.vscode-resource.vscode-webview.net/(file path)

linux_problem

In the system above(Windows 10), nothing happens when click this icon.

windows

@svsool
Copy link
Owner

svsool commented Nov 7, 2021

Hi, thanks for reporting.

Seems like a Windows specific problem. Last time I tested paths worked fine in preview under Windows, so it could be related to some recent updates in VSCode. Likely logic here and here should be checked.

Do you btw use latest version of this extension?

@svsool svsool added the bug Something isn't working label Nov 7, 2021
@SuperSASS
Copy link
Author

Yes, I downloaded the extension from VSCode recently, and the version of it is 0.3.9.

@antulik
Copy link

antulik commented Nov 24, 2021

I'm experiencing the same issue

Mac Monterey 12.0.1
VS Code Version: 1.62.3
Memo Version: v0.3.9

Unable to open 'People.md': Unable to read file '/Users/anton/work/practice-ignition/knowledge-base/Users/anton/work/ignition/knowledge-base/notes/People.md' (Error: Unable to resolve nonexistent file '/Users/anton/work/ignition/knowledge-base/Users/anton/work/ignition/knowledge-base/notes/People.md').

Notice the folder path is duplicated /Users/anton/work/practice-ignition/knowledge-base

@proItheus
Copy link

The same issue in Arch linux : 无法读取文件'/home/proitheus/Documents/vscode-memo/home/proitheus/Documents/vscode-memo/help/Features/Features.md'

svsool added a commit that referenced this issue Dec 11, 2021
@svsool
Copy link
Owner

svsool commented Dec 12, 2021

Hi, it seems that internal logic for resolving links changed once again in VSCode inside markdown preview.

This problem should be fixed in the latest version of Memo (tested under macOS and Windows). Please update from Marketplace!

@svsool svsool closed this as completed Dec 12, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants