a11y checks #815
Merged
a11y checks #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
reviewed
Sep 3, 2017
test/validator/index.js
Outdated
| @@ -2,7 +2,7 @@ import * as fs from "fs"; | |||
| import assert from "assert"; | |||
| import { svelte, tryToLoadJson } from "../helpers.js"; | |||
|
|
|||
| describe("validate", () => { | |||
| describe.only("validate", () => { | |||
There was a problem hiding this comment.
yeah, forgot to remove it before pushing — it's just to make my life easier while I'm working on it (as I don't need to configure tests to run individually, or wait for the entire suite). will make sure I remove it before removing the WIP 😀
|
Have got through a decent number of these but need to take a pause now. Think we should merge this in and create an issue for the rest |
Closed
This was referenced Sep 5, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #374. I think the best way to approach this is to implement as many of the eslint-plugin-jsx-a11y rules as possible: