Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserveComments doesn't work #4730

Closed
bwbroersma opened this issue Apr 27, 2020 · 1 comment · Fixed by #4736
Closed

preserveComments doesn't work #4730

bwbroersma opened this issue Apr 27, 2020 · 1 comment · Fixed by #4736
Labels
bug compiler Changes relating to the compiler

Comments

@bwbroersma
Copy link
Contributor

Describe the bug
The compiler option preserveComments: true does nothing.

To Reproduce
See this repo. With minimal changes from the svelte/template. This is my output with missing comment.

Expected behavior
Keep the comment in the SSR.

Probably this is because of this todo:

svelte/src/compiler/compile/render_ssr/handlers/Comment.ts

Lines 5 to 9 in aabb23c

// TODO preserve comments
// if (options.preserveComments) {
// renderer.append(`<!--${node.data}-->`);
// }

Information about your Svelte project:
svelte-3.21.0 & rollup.
@Conduitry Conduitry added the bug label Apr 27, 2020
confraria added a commit to confraria/svelte that referenced this issue Apr 27, 2020
@confraria
Fix perserveComments on ssr (sveltejs#4730)
06a8668
@confraria confraria mentioned this issue Apr 27, 2020
Merged
tanhauhau pushed a commit to tanhauhau/svelte that referenced this issue Jun 22, 2021
@confraria @tanhauhau
Fix perserveComments on ssr (sveltejs#4730)
332b8e8
@pngwn pngwn added compiler Changes relating to the compiler and removed triage: has pr labels Jun 26, 2021
dummdidumm pushed a commit that referenced this issue Jun 28, 2021
@confraria @tanhauhau
Fix preserveComments on ssr (#4736)
554d5dd 
Fixes #4730

Co-authored-by: tanhauhau <lhtan93@gmail.com>
@Conduitry
Copy link
Member

This should be fixed in 3.39.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compiler Changes relating to the compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix perserveComments on ssr (#4730) confraria/svelte
5 participants
@mindrones @tanhauhau @bwbroersma @pngwn @Conduitry