This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Stable sort #215
Merged
Stable sort #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgh
reviewed
Mar 25, 2018
| @@ -102,7 +102,10 @@ export default function create_routes({ files } = { files: glob.sync('**/*.*', { | |||
| } | |||
|
|
|||
| if (!a_sub_part.dynamic && a_sub_part.content !== b_sub_part.content) { | |||
| return b_sub_part.content.length - a_sub_part.content.length; | |||
| return ( | |||
| (b_sub_part.content.length - a_sub_part.content.length) || | |||
There was a problem hiding this comment.
Why not only alphabetically?
There was a problem hiding this comment.
Because a/b/foo.html needs to match before a/b/f[xx].html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a situation in which route sorting could be unstable, resulting in incorrect navigation. This fixes it. Also includes an unrelated commit I'd forgotten about, which binds
storeto error pages