Fix hash link reliability (fix #434)

sveltejs · Oct 13, 2018 · f2931b5 · f2931b5
1 parent abcac75
commit f2931b5
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/templates/src/client/start/index.ts b/templates/src/client/start/index.ts
@@ -83,6 +83,11 @@ function handle_click(event: MouseEvent) {
 	const svg = typeof a.href === 'object' && a.href.constructor.name === 'SVGAnimatedString';
 	const href = String(svg ? (<SVGAElement>a).href.baseVal : a.href);
 
+	// If we are clicking on the same hash we still want to scroll to it anyway.
+	if (location.hash && href === location.href) {
+		return;
+	}
+
 	if (href === location.href) {
 		event.preventDefault();
 		return;

diff --git a/test/apps/scroll/src/routes/tall-page.html b/test/apps/scroll/src/routes/tall-page.html
@@ -1,3 +1,4 @@
+<a href="tall-page#foo">scroll to foo</a>
 <div style="height: 9999px"></div>
 
 <div id="foo">

diff --git a/test/apps/scroll/test.ts b/test/apps/scroll/test.ts
@@ -33,6 +33,23 @@ describe('scroll', function() {
 		assert.ok(scrollY > 0, scrollY);
 	});
 
+	it('scrolls to any deeplink if it was already active', async () => {
+		await page.goto(`${base}/tall-page#foo`);
+		await start();
+
+		let scrollY = await page.evaluate(() => window.scrollY);
+		assert.ok(scrollY > 0, scrollY);
+
+		await page.evaluate(() => window.scrollTo(0, 0));
+		scrollY = await page.evaluate(() => window.scrollY);
+		assert.ok(scrollY === 0, scrollY);
+
+		await page.click('[href="tall-page#foo"]');
+		await wait(50);
+		scrollY = await page.evaluate(() => window.scrollY);
+		assert.ok(scrollY > 0, scrollY);
+	});
+
 	it('resets scroll when a link is clicked', async () => {
 		await page.goto(`${base}/tall-page#foo`);
 		await start();