Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more robust recovery from manifest errors #8095

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

follow-up to #8093:

  • clears the error overlay once the error is fixed (by doing a full page reload — not sure if there's a better way?)
  • removes the 'failed to update manifest' message — that's internal jargon we don't really use in a public-facing way
  • removes the stack trace — it's all internal stuff that's no help to the user
  • responds with an error page if the page is reloaded, instead of a) stumbling along with a stale manifest or b) in the case that the manifest was invalid from the start, failing with a cryptic internal error

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2022

🦋 Changeset detected

Latest commit: 40e7824

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

console.error(colors.bold().red('Failed to update manifest'));
manifest_error = /** @type {Error} */ (error);

console.error(colors.bold().red('Invalid routes'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be more than invalid routes (matchers for example) - I chose "manifest" because it was a more generic while not being completely opaque to the user

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's still okay — matchers are part of your routes

packages/kit/src/exports/vite/dev/index.js Outdated Show resolved Hide resolved
packages/kit/src/exports/vite/dev/index.js Outdated Show resolved Hide resolved
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@dummdidumm dummdidumm merged commit 0d89ff2 into master Dec 12, 2022
@dummdidumm dummdidumm deleted the manifest-error-recovery branch December 12, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants