Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Counter.svelte location in create-svelte template #522

Merged
merged 2 commits into from
Mar 14, 2021

Conversation

Conduitry
Copy link
Member

This should have been moved along with the other $lib stuff in #511. Right now a fresh copy of the template fails because it tries to import from $lib/Counter.svelte but the component isn't there.

@Conduitry
Copy link
Member Author

This will also be an opportunity to see whether the automated create-svelte publishes work now.

@Rich-Harris Rich-Harris merged commit 848687c into sveltejs:master Mar 14, 2021
@Conduitry Conduitry deleted the fix-template-path branch March 14, 2021 17:30
@melMass
Copy link

melMass commented Nov 9, 2021

Shouldn't this be done for the Skeleton template as well?

@Conduitry
Copy link
Member Author

Shouldn't this be done for the Skeleton template as well?

There's no Counter.svelte in the skeleton template.

@melMass
Copy link

melMass commented Nov 9, 2021

There's no Counter.svelte in the skeleton template.

I was referring to using $lib but you are right there is no components at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants