Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JSON parse error for non-JSON body in XMLHttpRequest #259

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Jun 10, 2024

Summary of change

In xmlhttprequest, a JSON.parse was being called on a non-JSON body when the status code was 403. This PR removes JSON.parse from the xmlhttprequest handler function. The onInvalidClaimResponse function gracefully handles all response body types, eliminating the need for JSON parsing in xmlhttprequest.

This issue existed for some time but was previously ignored. Recent changes in #258 exposed the error.

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Copy link

size-limit report 📦

Path Size
lib/build/bundleEntry.js 21.01 KB (-0.01% 🔽)

@rishabhpoddar rishabhpoddar merged commit 4518bff into 20.1 Jun 10, 2024
3 of 4 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/session-refresh-loop branch June 10, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants