-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make scram an optional feature #180
Conversation
Cargo.toml
Outdated
default = ["server-api-ring"] | ||
server-api-ring = ["server-api", "ring"] | ||
server-api-aws-lc-rs = ["server-api", "aws-lc-rs"] | ||
default = ["server-api"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scram should probably be enabled by default, tokio-rustls needs to bring in either ring or aws-lc-rs anyways, so even if someone disables scram they'll end up needing to specify rustls dependency themselves to enable a crypto provider, so even if someone disables scram you'll want separate ring/aws-lc-rs features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the notes. I will be thinking about that.
The updated feature sets:
|
|
This patch makes scram an optional feature completely as it introduces a few cypto libraries you might not want if you do not use scram in your application.
cc @serprex , this changes some behaviour introduced in #179