Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to origin 0.20.0. #139

Merged
merged 10 commits into from
Aug 22, 2024
Merged

Update to origin 0.20.0. #139

merged 10 commits into from
Aug 22, 2024

Conversation

sunfishcode
Copy link
Owner

No description provided.

@sunfishcode
Copy link
Owner Author

sunfishcode commented Jul 8, 2024

Fails with

inlinable function call in a function with debug info must have a !dbg location
  call void @_Unwind_Resume(ptr %197) #15
rustc-LLVM ERROR: Broken module found, compilation aborted!
error: could not compile `unwinding` (lib)

Probably a compiler bug.

@bjorn3
Copy link
Contributor

bjorn3 commented Jul 8, 2024

Does updating unwinding-rs work?

@sunfishcode
Copy link
Owner Author

It's already using unwinding v0.2.2, which is the latest version.

@bjorn3
Copy link
Contributor

bjorn3 commented Jul 8, 2024

rust-lang/rust#101121 has an identical error message but was supposedly fixed over a year ago already.

@sunfishcode
Copy link
Owner Author

With the latest nightly Rust, it now passes on x86-64 and i686, but it still fails on riscv64.

@sunfishcode sunfishcode changed the title Update to origin 0.19.0. Update to origin 0.20.0. Aug 20, 2024
@bjorn3
Copy link
Contributor

bjorn3 commented Aug 20, 2024

I can't reproduce the aarch64 failure locally.

Edit: I can't reproduce it on x86_64 cross compiling to aarch64, but I can reproduce it on aarch64 natively.

@bjorn3
Copy link
Contributor

bjorn3 commented Aug 20, 2024

I was able to reproduce crash independently of c-ward, but only when incr comp is disabled. I opened nbdd0121/unwinding#34 to track it on the unwinding side.

@sunfishcode sunfishcode reopened this Aug 21, 2024
@sunfishcode
Copy link
Owner Author

Adding these [profile.dev.package.unwinding] workarounds to all users isn't great, but I think it's the best option for now.

@sunfishcode sunfishcode merged commit 9e044b8 into main Aug 22, 2024
5 checks passed
@sunfishcode sunfishcode deleted the sunfishcode/update branch August 22, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants