Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Storybook 6.4 #1303

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Upgrade to Storybook 6.4 #1303

merged 4 commits into from
Dec 6, 2021

Conversation

robinmetral
Copy link
Contributor

@robinmetral robinmetral commented Dec 6, 2021

Purpose

Upgrades to Storybook 6.4.

Approach and changes

  • Ran the sb upgrade util (updates all sb dependencies)
  • Added minor tweaks to main.js
    • I had to add the new 6.4 emotionAlias: false; config, which is supposed to make sb compatible with emotion 11, but I still had to keep the old workaround in place (webpack aliases)
    • I had to add an extra webpack alias for @emotion/styled/base (legacy emotion 10) to @emotion/styled (emotion 11)
  • Addressed a deprecation warning for the sb CLI -s flag, which we were using to point to our storybook static dir
  • Fixed linting after prettier was bumped under the hood (in sb, the dependency changed from ~2.2.1 to ^2.2.1, resulting in an effective bump from 2.2.1 to 2.5.1)
  • Fixed the warnings we were getting about the babel loose mode when starting storybook, by declaring three underlying babel plugins in all babel configs with the loose option set to true. We were already doing this for a single one of these plugins

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2021

⚠️ No Changeset found

Latest commit: d225dff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/Gd61WmXBjKUkFdvWtEWMa41CDnix
✅ Preview: https://oss-circuit-ui-git-sb-6-4-sumup.vercel.app

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #1303 (d225dff) into main (044a7bc) will increase coverage by 0.03%.
The diff coverage is 84.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
+ Coverage   92.30%   92.34%   +0.03%     
==========================================
  Files         186      186              
  Lines        3667     3671       +4     
  Branches     1148     1147       -1     
==========================================
+ Hits         3385     3390       +5     
+ Misses        265      264       -1     
  Partials       17       17              
Impacted Files Coverage Δ
packages/circuit-ui/util/shared-prop-types.js 42.85% <11.11%> (+2.85%) ⬆️
packages/circuit-ui/components/Popover/Popover.tsx 96.07% <75.00%> (+0.03%) ⬆️
packages/circuit-ui/components/Table/utils.ts 93.75% <90.90%> (+0.20%) ⬆️
...omponents/CalendarTagTwoStep/CalendarTagTwoStep.js 61.22% <100.00%> (ø)
...it-ui/components/Card/components/Header/Header.tsx 92.30% <100.00%> (ø)
packages/circuit-ui/components/Col/utils.js 92.50% <100.00%> (+0.19%) ⬆️
.../components/ComponentsContext/ComponentsContext.ts 100.00% <100.00%> (ø)
...es/circuit-ui/components/IconButton/IconButton.tsx 89.47% <100.00%> (ø)
...cuit-ui/components/InlineMessage/InlineMessage.tsx 94.73% <100.00%> (-0.27%) ⬇️
...ircuit-ui/components/ModalContext/ModalContext.tsx 91.48% <100.00%> (+0.18%) ⬆️
... and 7 more

@sumup-oss sumup-oss deleted a comment from sumup-clark bot Dec 6, 2021
@robinmetral robinmetral marked this pull request as ready for review December 6, 2021 16:10
@robinmetral robinmetral requested a review from a team as a code owner December 6, 2021 16:10
@robinmetral robinmetral requested review from amelako and removed request for a team December 6, 2021 16:10
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop whoop, big kudos for getting this to work! 🚀

.storybook/.babelrc Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants