-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Storybook 6.4 #1303
Upgrade to Storybook 6.4 #1303
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/Gd61WmXBjKUkFdvWtEWMa41CDnix |
Codecov Report
@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
+ Coverage 92.30% 92.34% +0.03%
==========================================
Files 186 186
Lines 3667 3671 +4
Branches 1148 1147 -1
==========================================
+ Hits 3385 3390 +5
+ Misses 265 264 -1
Partials 17 17
|
…gins with loose option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoop whoop, big kudos for getting this to work! 🚀
Purpose
Upgrades to Storybook 6.4.
Approach and changes
main.js
emotionAlias: false;
config, which is supposed to make sb compatible with emotion 11, but I still had to keep the old workaround in place (webpack aliases)@emotion/styled/base
(legacy emotion 10) to@emotion/styled
(emotion 11)-s
flag, which we were using to point to our storybook static dir~2.2.1
to^2.2.1
, resulting in an effective bump from 2.2.1 to 2.5.1)true
. We were already doing this for a single one of these pluginsDefinition of done
Unit and integration testsMeets minimum browser supportMeets accessibility requirements