Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune](deps): Bump wandb from 0.10.19 to 0.10.22 in /python/requirements #13

Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Mar 13, 2021

Bumps wandb from 0.10.19 to 0.10.22.

Changelog

Sourced from wandb's changelog.

0.10.22 (March 9, 2021)

🐛 Bug Fix

  • Fix system metric logging rate in 0.10.x
  • Fix Audio external reference issue
  • Fix short runs with tensorboard_sync
  • Ignore wandb.init(id=) when running a sweep
  • Sanitize artifact metadata if needed

💅 Enhancement

  • Allow syncing of tfevents with wandb sync --sync-tensorboard

0.10.21 (March 2, 2021)

🐛 Bug Fix

  • Fix artifact.get() regression since 0.10.18
  • Allow 0 byte artifacts
  • Fix codesaving and program name reporting

💅 Enhancement

  • Added support for glb files for wandb.Object3D()
  • Added support for external references for wandb.Audio()
  • Custom chart support tensorboard pr_curves plugin
  • Support saving entire code directory in an artifact

0.10.20 (February 22, 2021)

🐛 Bug Fix

  • wandb.login() now respects disabled mode
  • handle exception when trying to log TPUs in colab

💅 Enhancement

  • Add WANDB_START_METHOD=thread to support non-multiprocessing
  • Add group and job_type to Run object in the export API
  • Improve artifact docstrings
Commits
  • 05d80c7 Bump version: 0.10.22.dev1 → 0.10.22
  • 8e7488d [WB-4647] changelog 0.10.22 (#1943)
  • 227bd5b [WB-4351] clarify run filtering regex syntax (#1941)
  • 22735a9 [WB-4916] - Revert cli stats logging to old cli defaults
  • eeeb291 [WB-4895]: Check for new files during tb_watcher shutdown (#1939)
  • d612b3f [WB-4896] Fixing Audio Reference and Making Artifact Test Better (#1937)
  • 9652aea [WB-4631] Fix/test dataframe removal (#1932)
  • b295bd7 [WB-4478] Feature/tb sync (#1852)
  • 424d73b [WB-4309]: Add telemetry for KerasCallback (#1896)
  • 9ccce16 [WB-4813]: sanitize artifact metadata (#1916)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 13, 2021
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 27, 2021

Superseded by #15.

@dependabot dependabot bot closed this Mar 27, 2021
@dependabot dependabot bot deleted the dependabot/pip/python/requirements/wandb-0.10.22 branch March 27, 2021 07:02
sumanthratna pushed a commit that referenced this pull request Aug 2, 2022
We encountered SIGSEGV when running Python test `python/ray/tests/test_failure_2.py::test_list_named_actors_timeout`. The stack is:

```
#0  0x00007fffed30f393 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /lib64/libstdc++.so.6
#1  0x00007fffee707649 in ray::RayLog::GetLoggerName() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#2  0x00007fffee70aa90 in ray::SpdLogMessage::Flush() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#3  0x00007fffee70af28 in ray::RayLog::~RayLog() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#4  0x00007fffee2b570d in ray::asio::testing::(anonymous namespace)::DelayManager::Init() [clone .constprop.0] ()
   from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#5  0x00007fffedd0d95a in _GLOBAL__sub_I_asio_chaos.cc () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#6  0x00007ffff7fe282a in call_init.part () from /lib64/ld-linux-x86-64.so.2
#7  0x00007ffff7fe2931 in _dl_init () from /lib64/ld-linux-x86-64.so.2
#8  0x00007ffff7fe674c in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
#9  0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#10 0x00007ffff7fe5ffe in _dl_open () from /lib64/ld-linux-x86-64.so.2
#11 0x00007ffff7d5f39c in dlopen_doit () from /lib64/libdl.so.2
#12 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#13 0x00007ffff7b82f13 in _dl_catch_error () from /lib64/libc.so.6
#14 0x00007ffff7d5fb09 in _dlerror_run () from /lib64/libdl.so.2
#15 0x00007ffff7d5f42a in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2
#16 0x00007fffef04d330 in py_dl_open (self=<optimized out>, args=<optimized out>)
    at /tmp/python-build.20220507135524.257789/Python-3.7.11/Modules/_ctypes/callproc.c:1369
```

The root cause is that when loading `_raylet.so`, `static DelayManager _delay_manager` is initialized and `RAY_LOG(ERROR) << "RAY_testing_asio_delay_us is set to " << delay_env;` is executed. However, the static variables declared in `logging.cc` are not initialized yet (in this case, `std::string RayLog::logger_name_ = "ray_log_sink"`).

It's better not to rely on the initialization order of static variables in different compilation units because it's not guaranteed. I propose to change all `RAY_LOG`s to `std::cerr` in `DelayManager::Init()`.

The crash happens in Ant's internal codebase. Not sure why this test case passes in the community version though.

BTW, I've tried different approaches:

1. Using a static local variable in `get_delay_us` and remove the global variable. This doesn't work because `init()` needs to access the variable as well.
2. Defining the global variable as type `std::unique_ptr<DelayManager>` and initialize it in `get_delay_us`. This works but it requires a lock to be thread-safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants