Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-4478] Feature/tb sync #1852

Merged
merged 18 commits into from
Mar 7, 2021
Merged

[WB-4478] Feature/tb sync #1852

merged 18 commits into from
Mar 7, 2021

Conversation

vanpelt
Copy link
Contributor

@vanpelt vanpelt commented Feb 17, 2021

https://wandb.atlassian.net/browse/WB-4478
https://wandb.atlassian.net/browse/CLI-708

Description

Syncs tensorboard event files with wandb sync and adds tests.

Testing

How was this PR tested?

@@ -484,6 +491,8 @@ def sync(
clean_old_hours=24,
clean_force=None,
):
# TODO: rather unfortunate, needed to avoid creating a `wandb` directory
os.environ["WANDB_DIR"] = TMPDIR.name
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raubitsj this one really sucks. I guess we can address it once we get rid of wandb.old and _get_cling_api... Not sure if it was worth it to dig deeper.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other people took a pass at not creating wandb dirs, but i think it wasnt done cleanly so it keeps coming back

self._step, len(dropped_keys)
)
)
print("\t" + ("\n\t".join(dropped_keys)))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the error that Graphcore was seeing, atleast now we tell the user exactly what keys we're dropping if a single "row" is more than 4 megabytes.

Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIrst pass look (i will do a full review tomorrow.

Do you want to put this in also? i think it is related, i havent had enough confidence in it without tests to put it in:
#1586

wandb/sdk/internal/tb_watcher.py Outdated Show resolved Hide resolved
wandb/sdk_py27/internal/file_stream.py Outdated Show resolved Hide resolved
wandb/sync/sync.py Outdated Show resolved Hide resolved
wandb/sync/sync.py Show resolved Hide resolved
wandb/sync/sync.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1852 (600adb1) into master (424d73b) will increase coverage by 1.08%.
The diff coverage is 93.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   73.81%   74.90%   +1.08%     
==========================================
  Files         233      233              
  Lines       28554    28754     +200     
==========================================
+ Hits        21078    21538     +460     
+ Misses       7476     7216     -260     
Impacted Files Coverage Δ
tests/test_library_public.py 100.00% <ø> (ø)
tests/utils/__init__.py 100.00% <ø> (ø)
wandb/sdk/internal/file_stream.py 82.42% <50.00%> (+11.33%) ⬆️
wandb/integration/tensorboard/log.py 80.57% <80.00%> (+4.57%) ⬆️
wandb/sync/sync.py 89.69% <88.11%> (+50.97%) ⬆️
tests/test_cli.py 92.11% <100.00%> (+1.13%) ⬆️
tests/test_public_api.py 98.95% <100.00%> (+0.02%) ⬆️
tests/utils/utils.py 64.93% <100.00%> (+3.50%) ⬆️
wandb/apis/public.py 73.19% <100.00%> (+0.22%) ⬆️
wandb/cli/cli.py 61.75% <100.00%> (+1.79%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424d73b...600adb1. Read the comment docs.

Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@raubitsj raubitsj changed the title Feature/tb sync [WB-4478] [WB-4478] Feature/tb sync Mar 7, 2021
@raubitsj raubitsj merged commit b295bd7 into master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants