Skip to content

Commit

Permalink
fix group membership update
Browse files Browse the repository at this point in the history
  • Loading branch information
suhancz committed Apr 10, 2024
1 parent b55a519 commit 013d14c
Showing 1 changed file with 14 additions and 12 deletions.
26 changes: 14 additions & 12 deletions tasks/ldap.yml
Original file line number Diff line number Diff line change
Expand Up @@ -186,18 +186,7 @@
loop: "{{ users }}"
loop_control:
loop_var: user_data_item
- name: Prepare LDIF to add admin user as LDAP directory manager
ansible.builtin.template:
src: ldap/ldap_admin_user.ldif.j2
dest: /var/tmp/{{ mailserver_admin_user }}_ldap_admin.ldif
mode: u=rw,og=r
owner: root
group: root
backup: yes
- name: Add admin user to admin groups
ansible.builtin.command: 'ldapmodify -c -x -h {{ mailserver_domain }} -D "cn=Directory Manager" -w "{{ ldap_admin_password }}" -f /var/tmp/{{ mailserver_admin_user }}_ldap_admin.ldif'
register: add_admin_user
changed_when: add_admin_user.rc != 0 and 'exists' in add_admin_user.stderr
- name: Set admin user group membership

Check failure on line 189 in tasks/ldap.yml

View workflow job for this annotation

GitHub Actions / Lint Code Base

syntax-check[specific]

'loop' is not a valid attribute for a Block
loop:
- "cn=Directory Administrators,dc={{ mailserver_domain | split('.') | join(',dc=') }}"
- "cn=Accounting Managers,ou=groups,dc={{ mailserver_domain | split('.') | join(',dc=') }}"
Expand All @@ -206,3 +195,16 @@
- "cn=PD Managers,ou=groups,dc={{ mailserver_domain | split('.') | join(',dc=') }}"
loop_control:
loop_var: group_dn
block:
- name: Prepare LDIF to add admin user as LDAP directory manager
ansible.builtin.template:
src: ldap/ldap_admin_user.ldif.j2
dest: /var/tmp/{{ mailserver_admin_user }}_{{ group_dn | split(',') | first | split('=') | last | replace(' ', '_') }}.ldif
mode: u=rw,og=r
owner: root
group: root
backup: yes
- name: Add admin user to admin groups
ansible.builtin.command: 'ldapmodify -c -x -h {{ mailserver_domain }} -D "cn=Directory Manager" -w "{{ ldap_admin_password }}" -f /var/tmp/{{ mailserver_admin_user }}_{{ group_dn | split(",") | first | split("=") | last | replace(" ", "_") }}.ldif'
register: add_admin_user
changed_when: add_admin_user.rc != 0 and 'exists' in add_admin_user.stderr

0 comments on commit 013d14c

Please sign in to comment.