This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Updating reqwest to 0.11.22 causes macos build failure, requires SystemConfiguration #686
Labels
Comments
jsantell
added a commit
that referenced
this issue
Oct 19, 2023
jsantell
added a commit
that referenced
this issue
Oct 19, 2023
jsantell
added a commit
that referenced
this issue
Oct 19, 2023
jsantell
added a commit
that referenced
this issue
Oct 31, 2023
jsantell
added a commit
that referenced
this issue
Nov 1, 2023
cdata
added a commit
that referenced
this issue
Nov 13, 2023
This was referenced Jan 17, 2024
Merged
jsantell
added
Chore
Non-user-facing feature
dependencies
Pull requests that update a dependency file
labels
Jan 22, 2024
Fixed upstream, should be fixed in next reqwest release (0.11.25) |
The macos system configuration dependency was made optional in 0.12 seanmonstar/reqwest#2185 |
jsantell
added a commit
that referenced
this issue
Mar 25, 2024
jsantell
added a commit
that referenced
this issue
Mar 25, 2024
jsantell
added a commit
that referenced
this issue
Mar 25, 2024
jsantell
added a commit
that referenced
this issue
Mar 25, 2024
jsantell
added a commit
that referenced
this issue
Mar 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
In some dev work, I updated
reqwest
from 0.11.20 to 0.11.22 and ran into failures in a x86_64 macos build:In seanmonstar/reqwest#1955, system-configuration was added to reqwest, requiring linking to the SystemConfiguration framework. The transitive dependency seems to link the framework in its build script at a glance, but we hit undefined symbol errors. Need to evaluate if this is an intended required change, and if so, learn more about if we want to require SystemConfiguration.framework on macos.
Upstream bug in system-configuration: mullvad/system-configuration-rs#41
Patch for iOS, to investigate: https://github.com/mullvad/system-configuration-rs/pull/42/files
Filed upstream Reqwest bug: seanmonstar/reqwest#2006
The text was updated successfully, but these errors were encountered: