Add test_password_could_achieve_max_length #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code for the fix looks good and the tests run fine on my local machine. It looks like the failing test from travis isn't related to any of the code that @oleksii-ti changed and their change looks good. 👍 |
vbrazo
force-pushed
the
master
branch
5 times, most recently
from
a359def
to
a5d7731
Compare
Fit Rubocop rules
vbrazo
reviewed
Jul 3, 2018
There was a problem hiding this comment.
@oleksii-ti travis is red because of a few rubocop violations.
Offenses:
lib/faker/internet.rb:61:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
test/test_faker_internet.rb:104:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
348 files inspected, 2 offenses detected
RuboCop failed!
Since these violations are simple, you could easily fix the trailing whitespace issues by running rubocop --only Layout/TrailingWhitespace -a.
vbrazo
changed the title
vbrazo
changed the title
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Fix bug when password always got min length * Update test_faker_internet.rb Fit Rubocop rules * Fit Rubocop rules * Fit Rubocop rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faker::Internet- Add a missing test