-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_password_could_achieve_max_length #372
Conversation
The code for the fix looks good and the tests run fine on my local machine. It looks like the failing test from travis isn't related to any of the code that @oleksii-ti changed and their change looks good. 👍 |
a359def
to
a5d7731
Compare
Fit Rubocop rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleksii-ti travis is red because of a few rubocop
violations.
Offenses:
lib/faker/internet.rb:61:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
test/test_faker_internet.rb:104:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
348 files inspected, 2 offenses detected
RuboCop failed!
Since these violations are simple, you could easily fix the trailing whitespace issues by running rubocop --only Layout/TrailingWhitespace -a
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Fix bug when password always got min length * Update test_faker_internet.rb Fit Rubocop rules * Fit Rubocop rules * Fit Rubocop rules
Faker::Internet
- Add a missing test