Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing types on grid options #355

Closed
theo-mesnil opened this issue Mar 10, 2022 · 2 comments · Fixed by #361
Closed

Missing types on grid options #355

theo-mesnil opened this issue Mar 10, 2022 · 2 comments · Fixed by #361

Comments

@theo-mesnil
Copy link
Contributor

🚀 Feature Proposal

We got missing types for grid options:

  • grid-column-start
  • grid-column-end
  • grid-row-start
  • grid-row-end

Example

<Box display="grid" gridColumnStart={5}>...</Box>

This example failed on TS.

Thanks :)
@theo-mesnil theo-mesnil changed the title Missing types son grid options Missing types on grid options Mar 10, 2022
gregberge added a commit that referenced this issue Apr 15, 2022
@gregberge
fix(types): fix missing values in types
699ea22 
Closes #355
@gregberge gregberge mentioned this issue Apr 15, 2022
Merged
gregberge added a commit that referenced this issue Apr 15, 2022
@gregberge
fix(types): fix missing values in types (#361)
01afa25 
Closes #355
@theo-mesnil
Copy link
Contributor Author

@gregberge hi !

These entries are still missing :

grid-column-start
grid-column-end
grid-row-start
grid-row-end

@gregberge
Copy link
Collaborator

Hi @theo-mesnil, feel free to submit a PR for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): fix missing values in types styled-components/xstyled
2 participants
@gregberge @theo-mesnil