Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md (fixes #125) #131

Merged
merged 2 commits into from
Apr 1, 2018
Merged

Update README.md (fixes #125) #131

merged 2 commits into from
Apr 1, 2018

Conversation

dfrankland
Copy link
Contributor

Added an FAQ section that outlines why Jest Styled Components might not be working.

@dfrankland
Update README.md (fixes styled-components#125)
27f1ed0 
Added an FAQ section that outlines why Jest Styled Components might not be working.
@dfrankland dfrankland mentioned this pull request Mar 24, 2018
Closed
@MicheleBertoli
Copy link
Member

Thank you very much, @dfrankland.

The information looks clear.
However, I'd ask you a couple of changes if you don't mind:

  • I don't really like this "Jest Styled Components may not work for several reasons" :)
  • As you suggested in the issue this could be a warning in the Global Installation section, or a subsection "Lerna" or "Several instances" - I wouldn't create a new FAQ section just for this

@dfrankland
Copy link
Contributor Author

Thanks for your feedback, excuse my cynical writing hahaha.

@MicheleBertoli
Copy link
Member

🙌Thank you very much, @dfrankland.

@MicheleBertoli MicheleBertoli merged commit 3d3a945 into styled-components:master Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfrankland @MicheleBertoli