Ensure cache miss to fix ESM compiling #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@probablyup welp, I am fully at a loss for how to test this. Do you have any guidance? I am also happy to cowboy it and say "It works with rollup, thanks" |
|
Can confirm that this fixes the issue for me 👍 |
quantizor
approved these changes
Jul 29, 2020
khmm12
added a commit
to khmm12/babel-plugin-styled-components
that referenced
this pull request
Jul 30, 2020
This reverts commit b1dcfda.
quantizor
pushed a commit
that referenced
this pull request
Jul 30, 2020
This was referenced Jul 10, 2024
This was referenced Jul 29, 2024
This was referenced Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this discussion: #234 that introduced the change to
cacheKey in localNameCache, the author referenced a comment you made here:#230 (comment)
in which, you indicated that the
falsevalue there was to ensure that the traversal would continue again until you either picked up the import or dynamically injected it (I think?)When the code was changed to account for this it failed to maintain the same behavior in the case that localName was intentionally left
false.This change ensures that the previous behavior (allowing the intentionally set
falseto fall through the cache lookup) remains, while ensuring afalsevalue in the cache does not ALSO fall through.Pardon the lack of supporting test. The only way I was able to reproduce this issue was when I was using rollup / babel to compile. I am still investigating what this difference is specifically to hopefully introduce a failing test prior to this commit.