Fix the issue of submenus not appearing #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, on the first installation, the submenus appear.
This reverts commit 90232a9.
The previous approach didn't work, as it gave the capabilities to more than admin users. Adding these custom capabilities on the plugins_loaded action looks to work.
kienstra
commented
Oct 17, 2020
| @@ -47,7 +47,7 @@ public function __construct() { | |||
| */ | |||
| public function register_hooks() { | |||
| add_action( 'init', [ $this, 'register_post_type' ] ); | |||
| add_action( 'admin_init', [ $this, 'add_caps' ] ); | |||
| add_action( 'plugins_loaded', [ $this, 'add_caps' ] ); | |||
There was a problem hiding this comment.
Maybe admin_init was a little too late to add the capabilities.
By moving it earlier to plugins_loaded, the capability is there in time for the submenus to be there.
|
It should also be possible to revert #23 |
The same issue that caused the submenus to not display also caused the link to not display. Now that the capability is added earlier, this works.
kienstra
requested review from
lukecarbis,
nickcernis and
mindctrl
and removed request for
lukecarbis
|
Hi @mindctrl and @nickcernis, |
nickcernis
approved these changes
Oct 19, 2020
mindctrl
approved these changes
Oct 19, 2020
|
Nice, thanks so much for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensures that on first activation, the block CPT menus appear:
This bug only appeared the first time GCB is ever activated on the site.
Testing instructions