-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two bugs #1
Comments
Do you have a redacted file that I can test with? I'm not sure whether it's all related to the negative amounts issue you mention, or whether the spec for net total shouldn't include other record transaction codes that aren't credit or debit. |
I changed the code already so the files I’m generating are correct – the net should be the difference between the debit and credit totals, as per the spec (though you lose the sign, so there’s no way of telling from that amount whether the debits totalled higher or lower than the credits). From: Stuart Attenborrow [mailto:notifications@github.com] Do you have a redacted file that I can test with? I'm not sure whether it's all related to the negative amounts issue you mention, or whether the spec for net total shouldn't include other record transaction codes that aren't credit or debit. — |
Your calculation of the net total is wrong (needs to be Math.Abs(debit - credit), and the Indicator field appears to need
for it to deserialize properly.
Also you get some strange errors deserializing if you use negative amounts.
The text was updated successfully, but these errors were encountered: